[MCKIN-7023] Improve XBlock i18n by allowing template translations

[pomegranited]

Uses temporary branches for XBlock, xblock-utils, and DnDv2-new to provide fixes for XBlock template translations.

JIRA tickets: MCKIN-7023

Discussions: WL-230, YONK-879

Dependencies:

• [MCKIN-7023] Allows translated strings in XBlock Django templates openedx-unsupported/xblock-utils#48
• [MCKIN-2723] Needs i18n runtime service to provide translations for HTML templates openedx/xblock-image-explorer#37
• [MCKIN-2723] Use i18n runtime service to provide translations for HTML templates openedx/xblock-drag-and-drop-v2#154
• [MCKIN-2723] DnDv3: Use i18n runtime service to provide translations for HTML templates open-craft/xblock-drag-and-drop-v2#25

Screenshots: See openedx/xblock-image-explorer#37 and openedx/xblock-drag-and-drop-v2#154 for before and after screenshots using dummy translations.

Merge deadline: ASAP

Testing instructions:

See openedx/xblock-image-explorer#37 for test instructions.

Author notes and concerns:

1. When the dependent PRs merge, we'll submit a follow-up PR to use the newly tagged versions of the dependent libraries.

Reviewers

• @mtyaka

[nedbat]

@pomegranited Am I right in thinking that any PR with "[MCKIN]" in the title isn't an OSPR?

[pomegranited]

@nedbat Yep totally -- though some people might omit the [], so if you're updating the OSPR trigger, then maybe just look for MCKIN-?

[nedbat]

Just manual for now.. :)

[bradenmacdonald]

@nedbat @pomegranited It's a little more complicated than that. If we submit work like this upstream to edx/edx-platform or edx/XBlock, then it would need an OSPR, even though it might have a MCKIN ticket associated with it. (Because edX is not paying us for this work.)

In general, OSPRs are never used for this repository/organization though, so a good rule of thumb is to not expect OSPRs for anything in the edx-solutions organization, with the only exception I know of being https://github.com/edx-solutions/xblock-drag-and-drop-v2 (which should really be moved to the edx org now anyways) and on that one I usually just ping Sandy Student for a review directly, since he's faster than the OSPR process :-p

[bradenmacdonald]

@pomegranited Note that in preparation for a Ginkgo rebase, this shouldn't be merged this week and we may need to target the integration branch instead of master. I'll send details tomorrow.

[pomegranited]

Thanks @bradenmacdonald edit saw your message, so changed the target to integration and rebased.

[bradenmacdonald]

Perfect, thanks @pomegranited !

[bradenmacdonald]

Note that we need to get a green CI build before merging.

[mtyaka]

Rebased on top of 'integration' from 291fa53e8b0f465cfc976903498b79bf9fbb4a59.

[mtyaka]

Removed 291fa53e8b0f465cfc976903498b79bf9fbb4a59 to see if it has any effect on tests which are still failing.

[pomegranited]

@mtyaka Ok, the only remaining issues are quality failures, which don't seem to be related to this ticket. What should I do?

[bradenmacdonald]

@pomegranited It's fine to ignore unrelated quality issues; another team is working on those things as part of the overall ginkgo upgrade. See #1040 (comment)

[pomegranited]

@bradenmacdonald Should I revert the quality-related commits, 2f5db08 and d86c03f?

[bradenmacdonald]

@pomegranited Probably, to make the team that's doing the rebase have an easier time, with fewer commits to deal with.

[pomegranited]

@bradenmacdonald done.

[mtyaka]

👍

• I tested this: I installed this branch on the solutions devstack and verified both versions of DnDv2 still work correctly.
• I read through the code
• I checked for accessibility issues n/a
• Includes documentation n/a

[pomegranited]

Thanks @mtyaka !

• Merged [MCKIN-2723] DnDv3: Use i18n runtime service to provide translations for HTML templates open-craft/xblock-drag-and-drop-v2#25 and soupdated a71bcd0#diff-e33f135f380bcb58445ffee1b9cdc992R10 to use the merge commit.
• Removed 5213d1fb6cd1b5a9444d9059c0151f7f3a2ff927, which was fixing a test failure that proved to no longer be necessary
• Rebased and squashed my commits
• Confirmed that tests are passing, except for the quality tests, which are being addressed elsewhere (cf MCKIN-7030 Add student_view_data to PB Recap components #1040 (comment))

Merging now.