Ref. 7288 Change removed when not on instance [7289] #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
706641e to
b9111b4
Compare
MiguelCompany
requested changes
Jan 20, 2020
| return false; | ||
| } | ||
| else | ||
| if (mp_subImpl->getAttributes().topic.getTopicKind() != NO_KEY) | ||
| { | ||
| t_m_Inst_Caches::iterator vit; | ||
| if (!find_key(change, &vit)) | ||
| { | ||
| return false; |
There was a problem hiding this comment.
I think we should also remove the change when the key is not found
|
Build status:
|
|
Build status:
|
SubscriberHistory::remove_change_sub should remove from the general RTPS history even though it didn't find the change in the instance's history. Failing to do so will result on the same change returned once and again every time a new change is added to the subscriber's history
7a14930 to
0102be9
Compare
MiguelCompany
approved these changes
Jan 22, 2020
|
Build status:
|
|
Errors not related to changes |
IkerLuengo
added a commit
that referenced
this pull request
Feb 21, 2020
This is a port of #961 from 1.9.x
IkerLuengo
added a commit
that referenced
this pull request
Feb 24, 2020
This is a port of #961 from 1.9.x
MiguelCompany
pushed a commit
that referenced
this pull request
Feb 24, 2020
This is a port of #961 from 1.9.x
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SubscriberHistory::remove_change_sub should remove from
the general RTPS history even though it didn't find
the change in the instance's history.
Failing to do so will result on the same change returned
once and again every time a new change is added
to the subscriber's history