Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove from history when change is not on instance <master> [7701] #1020

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Remove from history when change is not on instance <master> [7701] #1020

merged 1 commit into from
Feb 24, 2020

Conversation

IkerLuengo
Copy link
Contributor

This is a port of #961 from 1.9.x [7288]

@IkerLuengo IkerLuengo force-pushed the bugfix/remove_keyed_not_found/master branch from cd5394d to 9ce35c4 Compare February 21, 2020 09:00
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

MiguelCompany
MiguelCompany previously approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

MiguelCompany
MiguelCompany requested changes Feb 21, 2020
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and solve conflicts

@IkerLuengo IkerLuengo force-pushed the bugfix/remove_keyed_not_found/master branch from 9ce35c4 to 506c3ed Compare February 24, 2020 06:32
@richiware
Copy link
Member

richiware commented Feb 24, 2020 •
edited by MiguelCompany
Loading

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status <-- not related

MiguelCompany
MiguelCompany approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MiguelCompany MiguelCompany merged commit 0eefba1 into master Feb 24, 2020
@MiguelCompany MiguelCompany deleted the bugfix/remove_keyed_not_found/master branch February 24, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IkerLuengo @richiware @MiguelCompany