Ref. 7288 Remove the change also if the key is not found

eProsima · Jan 22, 2020 · 0102be9 · 0102be9
1 parent 1ed3d13
commit 0102be9
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/src/cpp/subscriber/SubscriberHistory.cpp b/src/cpp/subscriber/SubscriberHistory.cpp
@@ -415,34 +415,34 @@ bool SubscriberHistory::remove_change_sub(
     }
 
     std::lock_guard<RecursiveTimedMutex> guard(*mp_mutex);
-    if (mp_subImpl->getAttributes().topic.getTopicKind() != NO_KEY)
+    if (mp_subImpl->getAttributes().topic.getTopicKind() == WITH_KEY)
     {
-        t_m_Inst_Caches::iterator vit;
-        if (!find_key(change, &vit))
-        {
-            return false;
-        }
-
         bool found = false;
-        for (auto chit = vit->second.cache_changes.begin(); chit != vit->second.cache_changes.end(); ++chit)
+        t_m_Inst_Caches::iterator vit;
+        if (find_key(change, &vit))
         {
-            if ((*chit)->sequenceNumber == change->sequenceNumber && (*chit)->writerGUID == change->writerGUID)
+            for (auto chit = vit->second.cache_changes.begin(); chit != vit->second.cache_changes.end(); ++chit)
             {
-                vit->second.cache_changes.erase(chit);
-                found = true;
-                break;
+                if ((*chit)->sequenceNumber == change->sequenceNumber && (*chit)->writerGUID == change->writerGUID)
+                {
+                    vit->second.cache_changes.erase(chit);
+                    found = true;
+                    break;
+                }
             }
         }
         if (!found)
         {
             logWarning(SUBSCRIBER, "Change not found, something is wrong");
         }
     }
+
     if (remove_change(change))
     {
         m_isHistoryFull = false;
         return true;
     }
+
     return false;
 }