Configure Discovery Server using names [12349] #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLBuenoLopez
suggested changes
Aug 12, 2021
This tests have failed in today's nightly, even though they did not failed in #2061. This is related to the known hosts in the testing machines, and has anything to do with the tests of the implementation. |
JLBuenoLopez
previously approved these changes
Aug 12, 2021
|
@richiprosima please test windows |
Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
30c502e to
460f8e3
Compare
369998d to
1cc6e32
Compare
Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
1cc6e32 to
9434449
Compare
SamuelWHalodi
pushed a commit
to SamuelWHalodi/Fast-DDS
that referenced
this pull request
Oct 4, 2021
* Refs 12349: Use cross-platform get_env Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12349: Specify locators as DNS in fastdds CLI Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12349: Specify locators as DNS in environment variable Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12349: Allow names in locators using XML Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12349: Fix ServerClientEnvironmentSetUp test Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12349: Apply suggestions Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12349: Update fds help Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12349: Apply suggestions Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> Signed-off-by: Samuel Wilhelmsson <samuel@halodi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows configuring both Discovery Servers and Clients specifying names instead of IPv4 addresses (port is still required). If a name is specified, the DNS is queried for IPv4 addresses, which are in turn used to configure the Server and Client.