Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration of Discovery Server using names instead of addresses [12349] #282

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Configuration of Discovery Server using names instead of addresses [12349] #282

merged 2 commits into from
Aug 13, 2021

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Aug 12, 2021

EduPonz added 2 commits August 12, 2021 16:28
@EduPonz
Refs 12349: Add DNS section in Discovery Server
0b98f44 
Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
@EduPonz
Refs 12349: Add DNS explanation on CLI and env var
295f743 
Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
@EduPonz EduPonz requested a review from JLBuenoLopez August 12, 2021 18:59
@EduPonz EduPonz mentioned this pull request Aug 12, 2021
Merged
3 tasks
JLBuenoLopez
JLBuenoLopez approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit b1d9099 into master Aug 13, 2021
@EduPonz EduPonz deleted the feature/create_servers_dns branch August 13, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EduPonz @JLBuenoLopez