Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve ip name [11726] #2061

Merged
merged 15 commits into from
Aug 11, 2021
Merged

Resolve ip name [11726] #2061

merged 15 commits into from
Aug 11, 2021

Conversation

IkerLuengo
Copy link
Contributor

Resolve IP by DNS on locators.

MiguelCompany
MiguelCompany requested changes Jul 12, 2021
View reviewed changes
include/fastdds/rtps/common/Locator.h Outdated Show resolved Hide resolved
include/fastrtps/utils/IPLocator.h Outdated Show resolved Hide resolved
test/unittest/utils/LocatorTests.cpp Outdated Show resolved Hide resolved
test/unittest/utils/LocatorTests.cpp Outdated Show resolved Hide resolved
test/unittest/utils/LocatorTests.cpp Outdated Show resolved Hide resolved
test/unittest/utils/LocatorTests.cpp Show resolved Hide resolved
test/unittest/utils/LocatorTests.cpp Outdated Show resolved Hide resolved
test/unittest/utils/LocatorTests.cpp Show resolved Hide resolved
MiguelCompany
MiguelCompany requested changes Jul 12, 2021
View reviewed changes
test/unittest/utils/LocatorTests.cpp Show resolved Hide resolved
test/unittest/utils/LocatorTests.cpp Outdated Show resolved Hide resolved
test/unittest/utils/LocatorTests.cpp Outdated Show resolved Hide resolved
test/unittest/utils/LocatorTests.cpp Outdated Show resolved Hide resolved
test/unittest/utils/LocatorTests.cpp Outdated Show resolved Hide resolved
src/cpp/utils/IPLocator.cpp Outdated Show resolved Hide resolved
@MiguelCompany MiguelCompany added this to the v2.4.0 milestone Jul 12, 2021
MiguelCompany
MiguelCompany requested changes Jul 14, 2021
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Wait for CI infrastructure for setting specific host names
  2. Fix uncrustify -> ae83e73
  3. Filter out the DNS dependent tests when EPROSIMA_BUILD is off

@MiguelCompany
Copy link
Member

@richiprosima Please test linux

1 similar comment
@MiguelCompany
Copy link
Member

@richiprosima Please test linux

@MiguelCompany
Copy link
Member

@richiprosima Please test windows

@MiguelCompany
Copy link
Member

@richiprosima Please test mac

@MiguelCompany MiguelCompany force-pushed the feature/resolve-ip-name branch from 9f1b653 to ae83e73 Compare July 28, 2021 10:24
MiguelCompany
MiguelCompany previously approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany
Copy link
Member

@richiprosima Please test this

1 similar comment
@MiguelCompany
Copy link
Member

@richiprosima Please test this

@MiguelCompany
Copy link
Member

@richiprosima Please test Linux

@MiguelCompany
Copy link
Member

@richiprosima Please test this

@MiguelCompany
Copy link
Member

@richiprosima Please test aarch64

@MiguelCompany
Copy link
Member

@richiprosima Please test this

MiguelCompany
MiguelCompany previously approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jparisu and others added 12 commits August 6, 2021 10:33
@MiguelCompany
Refs #11726: DNS method and test (still finish the fastdds integratio…
cd4726a 
…n part

Signed-off-by: jparisu <javierparis@eprosima.com>
@IkerLuengo @MiguelCompany
Refs 11726. Check IPv6 elements are in bounds
050c1cd 
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
@IkerLuengo @MiguelCompany
Refs 11726. Use DNS resolver if no valid IP
a30c331 
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
@IkerLuengo @MiguelCompany
Refs 11726. Improve testing
15a974e 
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
@IkerLuengo @MiguelCompany
Refs 11726. Apply suggestions
1f07f6e 
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
@IkerLuengo @MiguelCompany
Refs 11726. Update cmake files
1d34869 
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
@IkerLuengo @MiguelCompany
Refs 11726. Apply suggestions
916716f 
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
@IkerLuengo @MiguelCompany
Refs 11726. Parse inetrface value before checking IP
e153a16 
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
@IkerLuengo @MiguelCompany
Refs 11726. Move DNS values to a common place
cf01bfc 
Also, start using TEST DNS values. These tests will not pass in the CI
until the changes in the CI configuration are merged

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
@MiguelCompany
Refs 11726. Fixed asio include dir
6a0c632 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11726. Uncrustify.
5d9d039 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11726. Correctly using asio standalone.
3075cc4 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11726. Skip DNS tests when EPROSIMA_BUILD is off
8d016dd 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11726. Use windows compatible address.
a2c4723 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany force-pushed the feature/resolve-ip-name branch from 743fc14 to a2c4723 Compare August 6, 2021 09:16
@MiguelCompany
Copy link
Member

@richiprosima Please test windows

@MiguelCompany
Fix after rebase.
b1f20b0 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany force-pushed the feature/resolve-ip-name branch from 6b34a94 to b1f20b0 Compare August 6, 2021 11:15
MiguelCompany
MiguelCompany approved these changes Aug 6, 2021
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI!

@EduPonz
Copy link

EduPonz commented Aug 11, 2021

@richiprosima please test Linux

@EduPonz EduPonz merged commit e9a70f2 into master Aug 11, 2021
@EduPonz EduPonz deleted the feature/resolve-ip-name branch August 11, 2021 13:08
@EduPonz EduPonz mentioned this pull request Aug 12, 2021
Merged
3 tasks
SamuelWHalodi pushed a commit to SamuelWHalodi/Fast-DDS that referenced this pull request Oct 4, 2021
@IkerLuengo @MiguelCompany @SamuelWHalodi
Resolve ip name (eProsima#2061)
7ca8737 
* Refs #11726: DNS method and test (still finish the fastdds integration part

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs 11726. Check IPv6 elements are in bounds

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Refs 11726. Use DNS resolver if no valid IP

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Refs 11726. Improve testing

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Refs 11726. Apply suggestions

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Refs 11726. Update cmake files

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Refs 11726. Apply suggestions

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Refs 11726. Parse inetrface value before checking IP

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Refs 11726. Move DNS values to a common place

Also, start using TEST DNS values. These tests will not pass in the CI
until the changes in the CI configuration are merged

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Refs 11726. Fixed asio include dir

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11726. Uncrustify.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11726. Correctly using asio standalone.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11726. Skip DNS tests when EPROSIMA_BUILD is off

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11726. Use windows compatible address.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Fix after rebase.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Co-authored-by: jparisu <javierparis@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Samuel Wilhelmsson <samuel@halodi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@IkerLuengo @MiguelCompany @EduPonz