Notify status changes [11835] #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
60f4301 to
b69c53c
Compare
…ionImpl::get_raw_status. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
b69c53c to
0f44131
Compare
MiguelCompany
added a commit
that referenced
this pull request
Jul 5, 2021
* Refs 11835. Fixed listener calls for deadline statuses. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Basic notifications on DataWriterImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Basic notifications on DataReaderImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Implementing DataReader::get_subscription_matched_status. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Fixed unit test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Implementing DataWriter::get_publication_matched_status. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Fixed unit test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Implement Entity::get_status_changes through StatusConditionImpl::get_raw_status. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Added StatusConditionImpl::get_raw_status to unit test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
added a commit
that referenced
this pull request
Jul 9, 2021
* Refs 11835. Fixed listener calls for deadline statuses. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Basic notifications on DataWriterImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Basic notifications on DataReaderImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Implementing DataReader::get_subscription_matched_status. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Fixed unit test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Implementing DataWriter::get_publication_matched_status. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Fixed unit test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Implement Entity::get_status_changes through StatusConditionImpl::get_raw_status. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Added StatusConditionImpl::get_raw_status to unit test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
added a commit
that referenced
this pull request
Aug 5, 2021
* Refs 11835. Fixed listener calls for deadline statuses. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Basic notifications on DataWriterImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Basic notifications on DataReaderImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Implementing DataReader::get_subscription_matched_status. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Fixed unit test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Implementing DataWriter::get_publication_matched_status. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Fixed unit test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Implement Entity::get_status_changes through StatusConditionImpl::get_raw_status. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Added StatusConditionImpl::get_raw_status to unit test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
added a commit
that referenced
this pull request
Aug 30, 2021
* Refs 11835. Fixed listener calls for deadline statuses. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Basic notifications on DataWriterImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Basic notifications on DataReaderImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Implementing DataReader::get_subscription_matched_status. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Fixed unit test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Implementing DataWriter::get_publication_matched_status. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Fixed unit test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Implement Entity::get_status_changes through StatusConditionImpl::get_raw_status. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Added StatusConditionImpl::get_raw_status to unit test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
added a commit
that referenced
this pull request
Aug 31, 2021
* WaitSet detail classes (#1989) * Refs 11608. Required changes on Condition API. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. ConditionNotifier with empty implementation. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. WaitSetImpl with empty implementation. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. ConditionNotifier unit test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. WaitSetImpl unit test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Added unordered_vector. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. ConditionNotifier implementation. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Condition management on WaitSetImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Implenting wait and wake_up on WaitSetImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11656. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11656. Solving link issues. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11656. Doxygen improvements. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11656. Check vector size on test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * WaitSet, Condition and GuardCondition implementation (#1991) * Refs 11608. Add ConditionNotifier to condition. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. WaitSetImpl attaches to notifier on attach_condition. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. WaitSetImpl detaches from notifier on detach_condition. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Adding expectations to WaitSetImplTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Waiting on an empty WaitSet should timeout. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Add WaitSetImpl to WaitSet. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Adapting ConditionTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Added GuardCondition implementation. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608.Unregister conditions on WaitSetImpl destruction. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Fixing WaitSetImplTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Explicit memory order on GuardCondition. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Includes alpha-sort. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11609. Explicitly setting GuardCondition initial value. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * StatusCondition unit tests (#2026) * Refs 11823. Added StatusConditionImpl header. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11823. Added StatusConditionImpl empty implementation. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11823. Added unit test infrastructure. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11823. Added StatusConditionImplTests tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11823. Entity returns non-const StatusCondition. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11823. Added StatusCondition::get_impl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11823. Added basic test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11823. Added trigger test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11823. Fixed warnings. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11823. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11823. Using StrictMock. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11823. Improved doxydoc. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * StatusCondition implementation (#2029) * Refs 11824. Added attributes to StatusConditionImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11824. Compositing StatusConditionImpl inside StatusCondition. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11824. Fixed link issues. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11824. Adding implementation to StatusConditionImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11824. Fixed Entity::get_statuscondition. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11824. Added StatusCondition::get_trigger_value. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11824. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11824. Changed EntityTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Notify status changes (#2030) * Refs 11835. Fixed listener calls for deadline statuses. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Basic notifications on DataWriterImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Basic notifications on DataReaderImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Implementing DataReader::get_subscription_matched_status. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Fixed unit test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Implementing DataWriter::get_publication_matched_status. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Fixed unit test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Implement Entity::get_status_changes through StatusConditionImpl::get_raw_status. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Added StatusConditionImpl::get_raw_status to unit test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Status condition blackbox (#2052) * Refs 11834. Linux compilation errors with gmock 1.10 Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 11834. pubsub reader/writer with waitsets instead of listeners Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 11834. Waitset blackbox Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 11834. Uncrustify Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 11834. Methods to check timeouts in waitsets Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 11834. Check that when no data is received, the waitset times out Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 11834. signed-unsigned comparison Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 11834. Suggested changes Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Fix after rebase Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: IkerLuengo <57146230+IkerLuengo@users.noreply.github.com>
SamuelWHalodi
pushed a commit
to SamuelWHalodi/Fast-DDS
that referenced
this pull request
Oct 4, 2021
* WaitSet detail classes (eProsima#1989) * Refs 11608. Required changes on Condition API. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. ConditionNotifier with empty implementation. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. WaitSetImpl with empty implementation. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. ConditionNotifier unit test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. WaitSetImpl unit test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Added unordered_vector. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. ConditionNotifier implementation. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Condition management on WaitSetImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Implenting wait and wake_up on WaitSetImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11656. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11656. Solving link issues. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11656. Doxygen improvements. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11656. Check vector size on test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * WaitSet, Condition and GuardCondition implementation (eProsima#1991) * Refs 11608. Add ConditionNotifier to condition. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. WaitSetImpl attaches to notifier on attach_condition. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. WaitSetImpl detaches from notifier on detach_condition. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Adding expectations to WaitSetImplTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Waiting on an empty WaitSet should timeout. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Add WaitSetImpl to WaitSet. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Adapting ConditionTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Added GuardCondition implementation. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608.Unregister conditions on WaitSetImpl destruction. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Fixing WaitSetImplTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Explicit memory order on GuardCondition. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Includes alpha-sort. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11608. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11609. Explicitly setting GuardCondition initial value. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * StatusCondition unit tests (eProsima#2026) * Refs 11823. Added StatusConditionImpl header. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11823. Added StatusConditionImpl empty implementation. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11823. Added unit test infrastructure. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11823. Added StatusConditionImplTests tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11823. Entity returns non-const StatusCondition. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11823. Added StatusCondition::get_impl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11823. Added basic test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11823. Added trigger test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11823. Fixed warnings. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11823. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11823. Using StrictMock. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11823. Improved doxydoc. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * StatusCondition implementation (eProsima#2029) * Refs 11824. Added attributes to StatusConditionImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11824. Compositing StatusConditionImpl inside StatusCondition. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11824. Fixed link issues. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11824. Adding implementation to StatusConditionImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11824. Fixed Entity::get_statuscondition. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11824. Added StatusCondition::get_trigger_value. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11824. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11824. Changed EntityTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Notify status changes (eProsima#2030) * Refs 11835. Fixed listener calls for deadline statuses. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Basic notifications on DataWriterImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Basic notifications on DataReaderImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Implementing DataReader::get_subscription_matched_status. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Fixed unit test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Implementing DataWriter::get_publication_matched_status. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Fixed unit test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Implement Entity::get_status_changes through StatusConditionImpl::get_raw_status. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11835. Added StatusConditionImpl::get_raw_status to unit test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Status condition blackbox (eProsima#2052) * Refs 11834. Linux compilation errors with gmock 1.10 Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 11834. pubsub reader/writer with waitsets instead of listeners Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 11834. Waitset blackbox Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 11834. Uncrustify Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 11834. Methods to check timeouts in waitsets Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 11834. Check that when no data is received, the waitset times out Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 11834. signed-unsigned comparison Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 11834. Suggested changes Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Fix after rebase Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: IkerLuengo <57146230+IkerLuengo@users.noreply.github.com> Signed-off-by: Samuel Wilhelmsson <samuel@halodi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
StatusConditionDataReader::get_subscription_matched_statusDataWriter::get_publication_matched_statusEntity::get_status_changesto use the raw status onStatusConditionImpl