Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WaitSet detail classes [11656] #1989

Merged
merged 13 commits into from
May 27, 2021

Conversation

MiguelCompany
Copy link
Member

This PR includes implementation detail classes, along with their unit tests, required to build Condition and WaitSet

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few nitpicks...

src/cpp/fastdds/core/condition/ConditionNotifier.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/core/condition/WaitSetImpl.hpp Outdated Show resolved Hide resolved
test/unittest/dds/core/condition/WaitSetImplTests.cpp Outdated Show resolved Hide resolved
* @file unordered_vector.hpp
*/

#ifndef SRC_CPP_UTILS_COLLECTIONS_UNORDERED_VECTOR_HPP_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This header guard is consistent with the other header guards in files within src/cpp/utils/collections but it does not follow the code style. I am good leaving it as it is.

src/cpp/fastdds/core/condition/WaitSetImpl.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/core/condition/WaitSetImpl.hpp Outdated Show resolved Hide resolved
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Copy link
Member Author

@JLBuenoLopez-eProsima I addressed your nitpicks

Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MiguelCompany MiguelCompany changed the base branch from master to feature/waitsets/impl May 27, 2021 14:32
@MiguelCompany MiguelCompany merged commit 7a78598 into feature/waitsets/impl May 27, 2021
@MiguelCompany MiguelCompany deleted the feature/waitsets/detail branch May 27, 2021 14:37
MiguelCompany added a commit that referenced this pull request Jun 4, 2021
* Refs 11608. Required changes on Condition API.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier with empty implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. WaitSetImpl with empty implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. WaitSetImpl unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Added unordered_vector.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Condition management on WaitSetImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Implenting wait and wake_up on WaitSetImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Solving link issues.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Doxygen improvements.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Check vector size on test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Jun 16, 2021
* Refs 11608. Required changes on Condition API.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier with empty implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. WaitSetImpl with empty implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. WaitSetImpl unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Added unordered_vector.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Condition management on WaitSetImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Implenting wait and wake_up on WaitSetImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Solving link issues.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Doxygen improvements.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Check vector size on test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Jun 24, 2021
* Refs 11608. Required changes on Condition API.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier with empty implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. WaitSetImpl with empty implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. WaitSetImpl unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Added unordered_vector.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Condition management on WaitSetImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Implenting wait and wake_up on WaitSetImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Solving link issues.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Doxygen improvements.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Check vector size on test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Jul 5, 2021
* Refs 11608. Required changes on Condition API.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier with empty implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. WaitSetImpl with empty implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. WaitSetImpl unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Added unordered_vector.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Condition management on WaitSetImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Implenting wait and wake_up on WaitSetImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Solving link issues.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Doxygen improvements.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Check vector size on test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Jul 9, 2021
* Refs 11608. Required changes on Condition API.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier with empty implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. WaitSetImpl with empty implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. WaitSetImpl unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Added unordered_vector.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Condition management on WaitSetImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Implenting wait and wake_up on WaitSetImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Solving link issues.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Doxygen improvements.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Check vector size on test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Aug 5, 2021
* Refs 11608. Required changes on Condition API.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier with empty implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. WaitSetImpl with empty implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. WaitSetImpl unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Added unordered_vector.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Condition management on WaitSetImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Implenting wait and wake_up on WaitSetImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Solving link issues.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Doxygen improvements.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Check vector size on test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Aug 30, 2021
* Refs 11608. Required changes on Condition API.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier with empty implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. WaitSetImpl with empty implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. WaitSetImpl unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Added unordered_vector.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Condition management on WaitSetImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Implenting wait and wake_up on WaitSetImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Solving link issues.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Doxygen improvements.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Check vector size on test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Aug 31, 2021
* WaitSet detail classes (#1989)

* Refs 11608. Required changes on Condition API.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier with empty implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. WaitSetImpl with empty implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. WaitSetImpl unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Added unordered_vector.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Condition management on WaitSetImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Implenting wait and wake_up on WaitSetImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Solving link issues.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Doxygen improvements.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Check vector size on test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* WaitSet, Condition and GuardCondition implementation (#1991)

* Refs 11608. Add ConditionNotifier to condition.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. WaitSetImpl attaches to notifier on attach_condition.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. WaitSetImpl detaches from notifier on detach_condition.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Adding expectations to WaitSetImplTests.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Waiting on an empty WaitSet should timeout.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Add WaitSetImpl to WaitSet.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Adapting ConditionTests.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Added GuardCondition implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608.Unregister conditions on WaitSetImpl destruction.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Fixing WaitSetImplTests.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Explicit memory order on GuardCondition.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Includes alpha-sort.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11609. Explicitly setting GuardCondition initial value.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* StatusCondition unit tests (#2026)

* Refs 11823. Added StatusConditionImpl header.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11823. Added StatusConditionImpl empty implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11823. Added unit test infrastructure.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11823. Added StatusConditionImplTests tests.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11823. Entity returns non-const StatusCondition.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11823. Added StatusCondition::get_impl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11823. Added basic test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11823. Added trigger test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11823. Fixed warnings.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11823. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11823. Using StrictMock.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11823. Improved doxydoc.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* StatusCondition implementation (#2029)

* Refs 11824. Added attributes to StatusConditionImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11824. Compositing StatusConditionImpl inside StatusCondition.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11824. Fixed link issues.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11824. Adding implementation to StatusConditionImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11824. Fixed Entity::get_statuscondition.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11824. Added StatusCondition::get_trigger_value.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11824. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11824. Changed EntityTests.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Notify status changes (#2030)

* Refs 11835. Fixed listener calls for deadline statuses.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11835. Basic notifications on DataWriterImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11835. Basic notifications on DataReaderImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11835. Implementing DataReader::get_subscription_matched_status.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11835. Fixed unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11835. Implementing DataWriter::get_publication_matched_status.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11835. Fixed unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11835. Implement Entity::get_status_changes through StatusConditionImpl::get_raw_status.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11835. Added StatusConditionImpl::get_raw_status to unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Status condition blackbox (#2052)

* Refs 11834. Linux compilation errors with gmock 1.10

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Refs 11834. pubsub reader/writer with waitsets instead of listeners

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Refs 11834. Waitset blackbox

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Refs 11834. Uncrustify

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Refs 11834. Methods to check timeouts in waitsets

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Refs 11834. Check that when no data is received, the waitset times out

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Refs 11834. signed-unsigned comparison

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Refs 11834. Suggested changes

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Fix after rebase

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Co-authored-by: IkerLuengo <57146230+IkerLuengo@users.noreply.github.com>
SamuelWHalodi pushed a commit to SamuelWHalodi/Fast-DDS that referenced this pull request Oct 4, 2021
* WaitSet detail classes (eProsima#1989)

* Refs 11608. Required changes on Condition API.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier with empty implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. WaitSetImpl with empty implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. WaitSetImpl unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Added unordered_vector.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. ConditionNotifier implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Condition management on WaitSetImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Implenting wait and wake_up on WaitSetImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Solving link issues.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Doxygen improvements.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11656. Check vector size on test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* WaitSet, Condition and GuardCondition implementation (eProsima#1991)

* Refs 11608. Add ConditionNotifier to condition.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. WaitSetImpl attaches to notifier on attach_condition.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. WaitSetImpl detaches from notifier on detach_condition.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Adding expectations to WaitSetImplTests.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Waiting on an empty WaitSet should timeout.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Add WaitSetImpl to WaitSet.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Adapting ConditionTests.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Added GuardCondition implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608.Unregister conditions on WaitSetImpl destruction.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Fixing WaitSetImplTests.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Explicit memory order on GuardCondition.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Includes alpha-sort.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11608. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11609. Explicitly setting GuardCondition initial value.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* StatusCondition unit tests (eProsima#2026)

* Refs 11823. Added StatusConditionImpl header.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11823. Added StatusConditionImpl empty implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11823. Added unit test infrastructure.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11823. Added StatusConditionImplTests tests.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11823. Entity returns non-const StatusCondition.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11823. Added StatusCondition::get_impl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11823. Added basic test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11823. Added trigger test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11823. Fixed warnings.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11823. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11823. Using StrictMock.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11823. Improved doxydoc.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* StatusCondition implementation (eProsima#2029)

* Refs 11824. Added attributes to StatusConditionImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11824. Compositing StatusConditionImpl inside StatusCondition.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11824. Fixed link issues.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11824. Adding implementation to StatusConditionImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11824. Fixed Entity::get_statuscondition.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11824. Added StatusCondition::get_trigger_value.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11824. Linters.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11824. Changed EntityTests.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Notify status changes (eProsima#2030)

* Refs 11835. Fixed listener calls for deadline statuses.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11835. Basic notifications on DataWriterImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11835. Basic notifications on DataReaderImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11835. Implementing DataReader::get_subscription_matched_status.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11835. Fixed unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11835. Implementing DataWriter::get_publication_matched_status.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11835. Fixed unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11835. Implement Entity::get_status_changes through StatusConditionImpl::get_raw_status.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 11835. Added StatusConditionImpl::get_raw_status to unit test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Status condition blackbox (eProsima#2052)

* Refs 11834. Linux compilation errors with gmock 1.10

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Refs 11834. pubsub reader/writer with waitsets instead of listeners

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Refs 11834. Waitset blackbox

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Refs 11834. Uncrustify

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Refs 11834. Methods to check timeouts in waitsets

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Refs 11834. Check that when no data is received, the waitset times out

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Refs 11834. signed-unsigned comparison

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Refs 11834. Suggested changes

Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>

* Fix after rebase

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Co-authored-by: IkerLuengo <57146230+IkerLuengo@users.noreply.github.com>
Signed-off-by: Samuel Wilhelmsson <samuel@halodi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants