[10793] Collection of data and notification to listeners SUBSCRIPTION_THROUGHPUT #1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLBuenoLopez
previously approved these changes
May 17, 2021
| @@ -244,6 +247,13 @@ class StatisticsReaderImpl | |||
| */ | |||
| void on_nackfrag( | |||
| int32_t count); | |||
|
|
|||
| /** | |||
| * @brief Reports throughtput based on last added sample to history | |||
There was a problem hiding this comment.
Suggested change
| * @brief Reports throughtput based on last added sample to history | |
| * @brief Reports subscription throughtput based on last added sample to reader's history |
| @@ -131,6 +140,15 @@ class StatisticsReaderImpl | |||
| { | |||
| } | |||
|
|
|||
| /** | |||
| * @brief Reports throughtput based on last added sample to history | |||
There was a problem hiding this comment.
Suggested change
| * @brief Reports throughtput based on last added sample to history | |
| * @brief Reports subscription throughtput based on last added sample to reader's history |
70ff78c to
eb974a5
Compare
eb974a5 to
7649a96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #1955