Collection of data and notification to listeners RTPS_PACKETS_LOST [10795] #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c704de to
a65676b
Compare
a65676b to
cc8a2ff
Compare
cc8a2ff to
6afdc81
Compare
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
41ff744 to
36f1c16
Compare
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelBarro
suggested changes
May 18, 2021
There was a problem hiding this comment.
Please, correct the gtest fixture flaw you detected by replacing:
Fast-DDS/test/unittest/statistics/rtps/RTPSStatisticsTests.cpp
Lines 383 to 385 in 836e0d3
with
std::string str("https://github.com/eProsima/Fast-DDS.git");
writer_change->serializedPayload.length = std::min(length, static_cast<uint32_t>(str.length()));
memcpy(writer_change->serializedPayload.data,
str.c_str(),
writer_change->serializedPayload.length);
Comment on lines
1362
to
1363
| msg->length -= statistics_submessage_length; | ||
| msg->pos = msg->length; |
There was a problem hiding this comment.
In order to prevent side effects is better practice to stash the msg state before the read_statistics_submessage call using local variables.
Note that read_statistics_submessage original implementation avoided side effects and stashing would have prevented applying the correction twice.
| Entity2LocatorTraffic data{}; | ||
| rtps::StatisticsSubmessageData::Sequence seq_data{}; | ||
| }; | ||
| std::map<lost_traffic_key, lost_traffic_value> lost_traffic; |
There was a problem hiding this comment.
According to the style guide traffic and lost_traffic should be underscored.
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.