[10792] Collection of data and notification to listeners PUBLICATION_THROUGHPUT #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18e937b to
8bd4036
Compare
JLBuenoLopez
previously approved these changes
May 17, 2021
| @@ -172,6 +172,13 @@ class StatisticsWriterImpl | |||
| /// Notify listeners of DATA / DATA_FRAG counts | |||
| void on_data_sent(); | |||
|
|
|||
| /** | |||
| * @brief Reports throughtput based on last added sample to history | |||
There was a problem hiding this comment.
Suggested change
| * @brief Reports throughtput based on last added sample to history | |
| * @brief Reports publication throughtput based on last added sample to writer's history |
| @@ -78,6 +78,15 @@ class StatisticsWriterImpl | |||
| { | |||
| } | |||
|
|
|||
| /** | |||
| * @brief Reports throughtput based on last added sample to history | |||
There was a problem hiding this comment.
Suggested change
| * @brief Reports throughtput based on last added sample to history | |
| * @brief Reports publication throughtput based on last added sample to writer's history |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was decided to retake the concept of reporting rate instead of the number of bytes. The change simplifies things and if in the future the amount of bytes is necessary we can extend the idl.
The callback will return bytes/second ( payload size / time span since the last callback). We only need to keep the
timestamp of the last callback and initialize it on construction (creation is the first callback).