Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix heartbeat and ACKs issues [11003] #1862

Merged
merged 6 commits into from
Mar 29, 2021
Merged

Fix heartbeat and ACKs issues [11003] #1862

merged 6 commits into from
Mar 29, 2021

Conversation

MiguelCompany
Copy link
Member

This PR fixes two issues:

  • Too many piggyback heartbeats were being sent when a SHM transport is registered
  • ACKs were not correctly delivered on certain corner cases

@MiguelCompany
Refs 11001. Improve blackbox test by waiting for ACKs.
1070ac0 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11001. Fix SharedMemTransportDescriptor::min_send_buffer_size()
7e9d236 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11001. Removed unused local variable.
6e75e66 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11001. Sender resources created after starting WriterProxy.
b6d8e44 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11001. Uncrustify ReceiverResource.cpp
5033531 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11001. Fix locator support check on ReceiverResource.
1a91d9f 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
This was referenced Mar 26, 2021
Merged
Merged
Merged
Merged
@EduPonz EduPonz added this to the v2.3.0 milestone Mar 29, 2021
JLBuenoLopez
JLBuenoLopez approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only a nitpick that can be disregarded.

CI failures are unrelated to this PR.

src/cpp/rtps/network/ReceiverResource.cpp Show resolved Hide resolved
@MiguelCompany MiguelCompany merged commit 3c78a78 into master Mar 29, 2021
@MiguelCompany MiguelCompany deleted the bugfix/11001/master branch March 29, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelCompany @JLBuenoLopez @EduPonz