Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix heartbeat and ACKs issues <1.8.x> [11007] #1866

Merged
merged 4 commits into from
Mar 29, 2021
Merged

Fix heartbeat and ACKs issues <1.8.x> [11007] #1866

merged 4 commits into from
Mar 29, 2021

Conversation

MiguelCompany
Copy link
Member

Backport #1862 to 1.8.x

@MiguelCompany
Refs 11001. Improve blackbox test by waiting for ACKs.
fcc2116 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11001. Removed unused local variable.
5c50334 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11001. Fix locator support check on ReceiverResource.
4e447c6 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany added the skip-ci Automatically pass CI label Mar 26, 2021
@MiguelCompany MiguelCompany changed the title Fix heartbeat and ACKs issues <1.8.x> Fix heartbeat and ACKs issues <1.8.x> [11007] Mar 26, 2021
JLBuenoLopez
JLBuenoLopez suggested changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix code style. I suggest changing the label to no-test instead of skip-ci so the building is done.

@MiguelCompany MiguelCompany added no-aarch Skip build & test for aarch64 no-test Skip CI tests if PR marked with this label and removed skip-ci Automatically pass CI labels Mar 29, 2021
@MiguelCompany
Refs 11001. Uncrustify.
6302795 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
JLBuenoLopez
JLBuenoLopez approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Build errors are unrelated to this PR.

@MiguelCompany MiguelCompany merged commit e405272 into 1.8.x Mar 29, 2021
@MiguelCompany MiguelCompany deleted the bugfix/11001/1.8.x branch March 29, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
no-aarch Skip build & test for aarch64 no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @JLBuenoLopez