Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heartbeat and ACKs issues <2.0.x> [11006] #1865

Merged
merged 7 commits into from
Mar 29, 2021
Merged

Conversation

MiguelCompany
Copy link
Member

Backport #1862 to 2.0.x

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany changed the base branch from master to 2.0.x March 26, 2021 09:50
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@JLBuenoLopez
Copy link
Contributor

@richiprosima please test mac

Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please, fix code style. CI failures are unrelated. Mac CI has been relaunched.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany added the skip-ci Automatically pass CI label Mar 29, 2021
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MiguelCompany MiguelCompany merged commit 6cee7cd into 2.0.x Mar 29, 2021
@MiguelCompany MiguelCompany deleted the bugfix/11001/2.0.x branch March 29, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants