Force aligned param length <master> [7841] #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IkerLuengo
reviewed
Mar 11, 2020
| @@ -62,7 +62,6 @@ constexpr DestinationOrderQosPolicyKind BY_RECEPTION_TIMESTAMP_DESTINATIONORDER_ | |||
| constexpr DestinationOrderQosPolicyKind BY_SOURCE_TIMESTAMP_DESTINATIONORDER_QOS = | |||
| DestinationOrderQosPolicyKind::BY_SOURCE_TIMESTAMP_DESTINATIONORDER_QOS; | |||
| using DestinationOrderQosPolicy = fastdds::dds::DestinationOrderQosPolicy; | |||
| using UserDataQosPolicy = fastdds::dds::UserDataQosPolicy; | |||
There was a problem hiding this comment.
Why treat UserDataQosPolicy different from the rest of QosPolicy classes?
There was a problem hiding this comment.
The linker complained on non-defined UserDataQosPolicy::addToCDRMessage. This class is only being used inside other classes (ProxyData and DDS QoS), so it is almost impossible for a user to have been using it. In fact, as part of the DDS PSM changes we are making, this has already been done.
|
Build status:
|
|
Build status:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a forward port of #1047 + #1056