Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force aligned param length <1.9.x> [7840] #1047

Merged
merged 10 commits into from
Mar 9, 2020
Merged

Force aligned param length <1.9.x> [7840] #1047

merged 10 commits into from
Mar 9, 2020

Conversation

MiguelCompany
Copy link
Member

This should solve some interoperability problems discovered on ros2/build_farmer#268

@MiguelCompany MiguelCompany requested a review from IkerLuengo March 6, 2020 11:44
@MiguelCompany MiguelCompany changed the title Force aligned param length <1.9.x> Force aligned param length <1.9.x> [7840] Mar 6, 2020
@MiguelCompany MiguelCompany mentioned this pull request Mar 6, 2020
Closed
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

IkerLuengo
IkerLuengo suggested changes Mar 6, 2020
View reviewed changes
src/cpp/qos/QosPolicies.cpp Show resolved Hide resolved
src/cpp/qos/QosPolicies.cpp Outdated Show resolved Hide resolved
src/cpp/qos/QosPolicies.cpp Show resolved Hide resolved
include/fastrtps/qos/QosPolicies.h Show resolved Hide resolved
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

IkerLuengo
IkerLuengo previously approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

IkerLuengo
IkerLuengo previously approved these changes Mar 9, 2020
View reviewed changes
IkerLuengo
IkerLuengo approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany merged commit 61e0450 into 1.9.x Mar 9, 2020
@MiguelCompany MiguelCompany deleted the feature/force-aligned-param-length/1.9.x branch March 9, 2020 09:28
@MiguelCompany MiguelCompany mentioned this pull request Mar 11, 2020
Merged
@rotu rotu mentioned this pull request Mar 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IkerLuengo IkerLuengo IkerLuengo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelCompany @richiware @IkerLuengo