Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting template into macro [7931] #1065

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

MiguelCompany
Copy link
Member

It seems that compilers are having problems when building (except on release) after #1059 was merged.

This PR helps them work better by avoiding the use of a template that was being aliased more than once.

@MiguelCompany MiguelCompany changed the title Converting template into macro Converting template into macro [7931] Mar 13, 2020
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

Copy link
Contributor

@adolfomarver adolfomarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in:

Linux x64 Debug / RelWithDebInfo
VS2019 x64 Debug / RelWithDebInfo

The fail in linux is also happening with other PRs so I assume it has nothing to do with this PR.

Everything Looks Good To Me!

@MiguelCompany MiguelCompany merged commit 96a0033 into master Mar 17, 2020
@MiguelCompany MiguelCompany deleted the hotfix/template-to-macro/master branch March 17, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants