Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20411] Migrate to eProsima-CI #195

Merged
merged 4 commits into from
Feb 14, 2024
Merged

[20411] Migrate to eProsima-CI #195

merged 4 commits into from
Feb 14, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Feb 12, 2024 •
edited
Loading

This PR:

  • Refactors the build_and_test workflow so it becomes full multiplatform leveraging eProsima-CI
  • Fixes the CMake version used in CI
  • Adds a windows-2019 runner to the list of tests
  • Adds a Test summary step to the build_and_test workflow
  • Adds a Test reporting step to the build_and_test workflow
  • Correctly requires CMake 3.22 for testing

Depends on:

@EduPonz EduPonz force-pushed the feature/migrate_to_eprosima_ci branch from 62a3808 to 5487cea Compare February 12, 2024 15:19
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@EduPonz EduPonz force-pushed the feature/migrate_to_eprosima_ci branch 5 times, most recently from 0b9947b to 1327f95 Compare February 12, 2024 20:09
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@EduPonz
Refs #20423: Migrate to eProsima-CI and add Windows 2019 run
02ae97d 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20423: Require CMake 3.22 for testing
b918e14 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz force-pushed the feature/migrate_to_eprosima_ci branch from 1327f95 to b918e14 Compare February 13, 2024 06:13
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@EduPonz EduPonz changed the title [20441] Migrate to eProsima-CI [20411] Migrate to eProsima-CI Feb 13, 2024
@EduPonz EduPonz force-pushed the feature/migrate_to_eprosima_ci branch from 60d40a8 to 83dbd10 Compare February 13, 2024 10:23
@EduPonz
Refs #20423: Add a test summary step
464e7bc 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz force-pushed the feature/migrate_to_eprosima_ci branch 3 times, most recently from 10aabee to 464e7bc Compare February 13, 2024 14:01
@EduPonz EduPonz marked this pull request as ready for review February 13, 2024 14:22
@EduPonz
Refs #20423: Set v0 version for eProsima-CI actions
41a88db 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
JLBuenoLopez
JLBuenoLopez reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Pending approval when a release has been done in eProsima-CI including the required changes for this PR.

.github/workflows/fastcdr-test.yml Outdated Show resolved Hide resolved
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

JLBuenoLopez
JLBuenoLopez approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JLBuenoLopez JLBuenoLopez merged commit c045c23 into master Feb 14, 2024
14 checks passed
@JLBuenoLopez JLBuenoLopez deleted the feature/migrate_to_eprosima_ci branch February 14, 2024 06:04
@EduPonz
Copy link
Author

EduPonz commented Feb 14, 2024

@Mergifyio backport 1.1.x

@mergify Mergify
Copy link

mergify bot commented Feb 14, 2024 •
edited
Loading

backport 1.1.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 14, 2024
@EduPonz @mergify
Migrate to eProsima-CI (#195)
44b2590 
* Refs #20423: Migrate to eProsima-CI and add Windows 2019 run

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20423: Require CMake 3.22 for testing

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20423: Add a test summary step

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20423: Set v0 version for eProsima-CI actions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit c045c23)

# Conflicts:
#	.github/workflows/fastcdr-test.yml
#	cmake/testing/GoogleTest.cmake
@mergify mergify bot mentioned this pull request Feb 14, 2024
Merged
JesusPoderoso pushed a commit that referenced this pull request Feb 14, 2024
@EduPonz @JesusPoderoso
Migrate to eProsima-CI (#195)
833a20f 
* Refs #20423: Migrate to eProsima-CI and add Windows 2019 run

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20423: Require CMake 3.22 for testing

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20423: Add a test summary step

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20423: Set v0 version for eProsima-CI actions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit c045c23)
EduPonz added a commit that referenced this pull request Feb 14, 2024
@EduPonz
Migrate to eProsima-CI (#195)
8b9a575 
* Refs #20423: Migrate to eProsima-CI and add Windows 2019 run

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20423: Require CMake 3.22 for testing

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20423: Add a test summary step

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20423: Set v0 version for eProsima-CI actions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit c045c23)
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
EduPonz added a commit that referenced this pull request Feb 14, 2024
@mergify @EduPonz @JesusPoderoso
Migrate to eProsima-CI (#195) (#196)
bdceab5 
* Migrate to eProsima-CI (#195)

* Refs #20423: Migrate to eProsima-CI and add Windows 2019 run

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20423: Require CMake 3.22 for testing

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20423: Add a test summary step

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20423: Set v0 version for eProsima-CI actions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit c045c23)
Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Include 1.1.x as CI target branch

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Adjust to 1.1.x

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@EduPonz
Copy link
Author

EduPonz commented Feb 18, 2024

@Mergifyio backport 1.0.x

@mergify Mergify
Copy link

mergify bot commented Feb 18, 2024 •
edited
Loading

backport 1.0.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 18, 2024
@EduPonz @mergify
Migrate to eProsima-CI (#195)
be6e5eb 
* Refs #20423: Migrate to eProsima-CI and add Windows 2019 run

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20423: Require CMake 3.22 for testing

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20423: Add a test summary step

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20423: Set v0 version for eProsima-CI actions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit c045c23)

# Conflicts:
#	.github/workflows/fastcdr-test.yml
#	cmake/testing/GoogleTest.cmake
@mergify mergify bot mentioned this pull request Feb 18, 2024
Merged
EduPonz added a commit that referenced this pull request Feb 18, 2024
@EduPonz
Migrate to eProsima-CI (#195)
c7b7911 
* Refs #20423: Migrate to eProsima-CI and add Windows 2019 run

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20423: Require CMake 3.22 for testing

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20423: Add a test summary step

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20423: Set v0 version for eProsima-CI actions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit c045c23)

# Conflicts:
#	.github/workflows/fastcdr-test.yml
#	cmake/testing/GoogleTest.cmake
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
EduPonz added a commit that referenced this pull request Feb 19, 2024
@mergify @EduPonz
Migrate to eProsima-CI (#195) (#198)
d0b09bd 
* Migrate to eProsima-CI (#195)

* Refs #20423: Migrate to eProsima-CI and add Windows 2019 run

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20423: Require CMake 3.22 for testing

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20423: Add a test summary step

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20423: Set v0 version for eProsima-CI actions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit c045c23)

# Conflicts:
#	.github/workflows/fastcdr-test.yml
#	cmake/testing/GoogleTest.cmake
Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Adjust for 1.0.x

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Apply José's suggestions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EduPonz @richiprosima @JLBuenoLopez