Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix popup actions #208

Merged
merged 4 commits into from
Aug 3, 2023
Merged

fix popup actions #208

merged 4 commits into from
Aug 3, 2023

Conversation

TimPurdum
Copy link
Collaborator

@TimPurdum TimPurdum commented Aug 2, 2023

Closes #207
The view.popup.on function is not available until the view is rendered. Rather than do some sort of re-registration of the popupTemplate, I realized we could use a reactiveUtils.once to register the handler after the popup is ready.

Also in this PR

  • A few undefineds added to a jsBuilder to prevent null errors
  • Had to update the copyAssets.ps1. Powershell's default behavior seems to have changed. Christopher and I saw this before, now my version matches what his Mac was doing 3 months ago...
  • removed an old project reference from the solution file

@TimPurdum TimPurdum self-assigned this Aug 2, 2023
@@ -727,9 +731,9 @@ export function buildJsQuery(dotNetQuery: DotNetQuery): Query {
where: dotNetQuery.where ?? "1=1",
spatialRelationship: dotNetQuery.spatialRelationship as any ?? "intersects",
distance: dotNetQuery.distance ?? undefined,
units: dotNetQuery.units as any ?? null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

returnGeometry: dotNetQuery.returnGeometry ?? false,
outFields: dotNetQuery.outFields ?? null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I haven't actually improved anything here, but I also didn't hurt anything. I think I made this change as part of an investigation into an issue, and it seemed to make more sense to me to keep it undefined as more consistent.

Copy link
Collaborator

@AndersenBell AndersenBell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments on the default values that got updated.

Copy link
Collaborator

@seahro seahro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I had one question about possibly adding a note in the reactiveUtils or popup documentation about this method

Copy link
Contributor

@agnesstelmach agnesstelmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeScript looks good to me :)

@TimPurdum
Copy link
Collaborator Author

Looks good. I had one question about possibly adding a note in the reactiveUtils or popup documentation about this method
@seahro I don't think your actual question came through. However, I've been going off the thought that only the C# layer needs documentation, but that was for the public-facing customer. We can certainly add comments for the internal maintainers. I'll see about adding one here.

@TimPurdum TimPurdum merged commit f8b42c1 into develop Aug 3, 2023
@TimPurdum TimPurdum deleted the bug/207_popup_actions branch August 3, 2023 14:06
@TimPurdum TimPurdum mentioned this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup Actions not working
4 participants