fix popup actions #208
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -110,6 +110,7 @@ import ComboBoxInput from "@arcgis/core/form/elements/inputs/ComboBoxInput"; | |
| import RadioButtonsInput from "@arcgis/core/form/elements/inputs/RadioButtonsInput"; | ||
| import SwitchInput from "@arcgis/core/form/elements/inputs/SwitchInput"; | ||
| import Domain from "@arcgis/core/layers/support/Domain"; | ||
| import * as reactiveUtils from "@arcgis/core/core/reactiveUtils"; | ||
|
|
||
|
|
||
| export function buildJsSpatialReference(dotNetSpatialReference: DotNetSpatialReference): SpatialReference { | ||
|
|
@@ -260,9 +261,12 @@ export function buildJsPopupTemplate(popupTemplateObject: DotNetPopupTemplate, v | |
| if (hasValue(templateTriggerActionHandler)) { | ||
| templateTriggerActionHandler.remove(); | ||
| } | ||
| reactiveUtils.once(() => view.popup.on !== undefined) | ||
| .then(() => { | ||
| templateTriggerActionHandler = view.popup.on("trigger-action", async (event: PopupTriggerActionEvent) => { | ||
| await popupTemplateObject.dotNetPopupTemplateReference.invokeMethodAsync("OnTriggerAction", event.action.id); | ||
| }); | ||
| }) | ||
| } | ||
| catch (error) { | ||
| console.debug(error); | ||
|
|
@@ -727,9 +731,9 @@ export function buildJsQuery(dotNetQuery: DotNetQuery): Query { | |
| where: dotNetQuery.where ?? "1=1", | ||
| spatialRelationship: dotNetQuery.spatialRelationship as any ?? "intersects", | ||
| distance: dotNetQuery.distance ?? undefined, | ||
| units: dotNetQuery.units as any ?? undefined, | ||
| returnGeometry: dotNetQuery.returnGeometry ?? false, | ||
|
There was a problem hiding this comment. Same here, default value is null: There was a problem hiding this comment. Yes, I haven't actually improved anything here, but I also didn't hurt anything. I think I made this change as part of an investigation into an issue, and it seemed to make more sense to me to keep it |
||
| outFields: dotNetQuery.outFields ?? undefined, | ||
| orderByFields: dotNetQuery.orderByFields ?? undefined, | ||
| outStatistics: dotNetQuery.outStatistics ?? undefined, | ||
| groupByFieldsForStatistics: dotNetQuery.groupByFieldsForStatistics ?? undefined, | ||
|
|
@@ -748,7 +752,7 @@ export function buildJsQuery(dotNetQuery: DotNetQuery): Query { | |
| having: dotNetQuery.having ?? undefined, | ||
| historicMoment: dotNetQuery.historicMoment ?? undefined, | ||
| maxRecordCountFactor: dotNetQuery.maxRecordCountFactor ?? 1, | ||
| text: dotNetQuery.text ?? undefined, | ||
| parameterValues: dotNetQuery.parameterValues ?? undefined, | ||
| quantizationParameters: dotNetQuery.quantizationParameters ?? undefined, | ||
| rangeValues: dotNetQuery.rangeValues ?? undefined, | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://developers.arcgis.com/javascript/latest/api-reference/esri-rest-support-Query.html#units
The default value is null per the API?