Bug/214 sql filter #217
Merged
Bug/214 sql filter #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #214 , fixing the sql filter page, by reverting some bad changes to
arcGisJsInterop.updateLayer. Basically, FL's from the server (url or portal Id) were not getting some updates. I think the original change was to avoid an issue with trying to jam aSpatialReferenceon a server feature layer, so I left that property client-side only for updates. I also tested with core and pro samples, and could not recreate the original problem after this reversion.Also
view.popup.onexisting and not existing injsBuilder.buildJsPopupTemplateApplyEdits, it tries to pass back the FeatureLayer, but it is apparently huge, even without graphics loaded. I noticed thatFieldswere being passed as-is from ArcGIS, and theRendererI don't think needed to be passed.