Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #117 / #68 #118

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

larsga
Copy link
Collaborator

@larsga larsga commented Mar 1, 2023

This needs #113 to be merged first.

Also, I'm not 100% confident that this fix is correct, so please review carefully.

@larsga larsga requested a review from drmacro March 1, 2023 18:49
@larsga
Copy link
Collaborator Author

larsga commented Mar 1, 2023

And it's still unsigned. I have no idea what's wrong this time. Configured git to know about my key, then did the commit with -S. Will try to look into this more.

@drmacro drmacro changed the base branch from develop to feature/Issue-68-fix-last-section-properties March 12, 2023 17:12
@larsga larsga changed the base branch from feature/Issue-68-fix-last-section-properties to develop March 14, 2023 07:58
@larsga larsga force-pushed the lmg-multisection-extra-page-fix branch from c70f7e1 to 85dae34 Compare July 4, 2024 12:45
@larsga
Copy link
Collaborator Author

larsga commented Jul 4, 2024

I managed to fix this PR, too. Please, Eliot, could you merge this one, too? This is another fix that we really need to have in Wordinator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant