Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #109 #113

Closed
wants to merge 20 commits into from
Closed

Fix for issue #109 #113

wants to merge 20 commits into from

Conversation

larsga
Copy link
Collaborator

@larsga larsga commented Feb 23, 2023

We ensure that empty table cells in the input have at least an empty paragraph in the output.

Note that this PR builds on the "refactor tests" PR, so that needs to be merged first.

@larsga larsga added the bug Something isn't working label Feb 23, 2023
@larsga larsga requested a review from drmacro February 23, 2023 11:27
@larsga
Copy link
Collaborator Author

larsga commented Feb 23, 2023

And I see my commits are now suddenly unverified again. I don't know why, but will fix that.

This was referenced Feb 23, 2023
Closed
Open
@drmacro
Copy link
Owner

drmacro commented Mar 12, 2023

I'm going to close this PR because the branch is out of date and we can get the useful stuff from this branch manually or via cherry pick if needed.

We can resolve on the most appropriate code fix once the other PRs have been integrated--ultimately it's a small change to the table handling.

@drmacro drmacro closed this Mar 12, 2023
@larsga
Copy link
Collaborator Author

larsga commented Mar 14, 2023

This branch still has commits that we need to get onto develop, so reopening it.

@larsga larsga reopened this Mar 14, 2023
contrext and others added 15 commits December 29, 2023 10:55
@contrext @drmacro
Issue 130: Correct document-uri() to base-uri()
75db87d
@drmacro @contrext
Feature/issue 132 toc arg t (drmacro#135)
9493074 
* Fixes drmacro#132: Handle arg-t to set the \t parameter in the toc instruction

* Fixes drmacro#132: Added support for all TOC instruction options

* drmacro#132: Remove unwanted log statements

---------

Co-authored-by: Eliot Kimber <ekimber@contrext.com>
@drmacro @contrext
Fixes drmacro#134: Retain empty P in empty <td> (drmacro#137)
12c47f5 
Co-authored-by: Eliot Kimber <ekimber@contrext.com>
@drmacro @contrext
Feature/issue 136 external hyperlinks (drmacro#138)
036c500 
* Fixes drmacro#136: Test for external link rId passes

---------

Co-authored-by: Eliot Kimber <ekimber@contrext.com>
@ekimbernow
Feature/issue 87 toc generation (drmacro#141)
66b8af5 
* drmacro#87: Properly handle nested tocentry elements
@drmacro @ekimbernow
Fixes drmacro#140: Set up new markup for doc properties, implemented …
d2c7b6d 
…core pro… (drmacro#142)

* Issue 140: Set up new markup for doc properties, implemented core properties handling
---------

Co-authored-by: eliot.kimber <eliot.kimber@servicenow.com>
@drmacro @ekimbernow
ixes drmacro#143: keepLines and keepNext implemented
cfdbffa 
Co-authored-by: eliot.kimber <eliot.kimber@servicenow.com>
@drmacro @ekimbernow
Fixes drmacro#145: Implement missing subject property (drmacro#146)
2dea375 
Co-authored-by: eliot.kimber <eliot.kimber@servicenow.com>
@drmacro @ekimbernow
Fixes drmacro#147: Eliminated unsupported props, test remaining props…
51ecb4f 
… correctly (drmacro#148)

Co-authored-by: eliot.kimber <eliot.kimber@servicenow.com>
@ekimbernow
Updated release notes
a5d7c24
@ekimbernow @drmacro
drmacro#133: Updated to POI 2.5.2
72b7fa2
@ekimbernow @drmacro
Fixes drmacro#133, drmacro#105: Set compatibity mode setting to turn …
9efbf5f 
…off compatibility mode.
@larsga
Ensure empty table cells in input still have some content in output
81f36fa 
This fixes issue drmacro#109
@larsga
Ensure all table cells always end with a paragraph
c2b8d87
@larsga
Reimplement the fix on top of the fix for issue 134
9fd0e7e
@larsga larsga force-pushed the lmg-fix-issue-109 branch from 51597a1 to 9fd0e7e Compare July 4, 2024 10:33
@larsga
Copy link
Collaborator Author

larsga commented Jul 4, 2024

The fix for issue #134 was basically a fix for the same issue as this PR, but that fix was too simple. It's necessary for table cells to end with a paragraph if Word is to be happy. This PR has two automated tests that verify this, and the code currently in the repo fails those two tests.

I've now merged in all the code from the repo, and then reapplied these fixes on top.

It would be great if we could get this PR merged, because this is a fix we really need in our software. We have been using our own build of Wordinator (which has this fix), but we would very much like to switch to the standard Wordinator. That requires this issue to be fixed, though.

@ekimbernow ekimbernow changed the base branch from develop to feature/Issue-109-nested-table-corrupt-doc August 4, 2024 19:33
@ekimbernow
Copy link
Collaborator

Closing as complete.

I manually copied the code from this PR into the code on the develop branch. New test cases and update empty table cell cases pass, generated Word docs open without error.

@ekimbernow ekimbernow closed this Aug 4, 2024
@larsga
Copy link
Collaborator Author

larsga commented Aug 4, 2024

Thanks for incorporating the fix. I don't really care how it's done, as long as the problems get fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drmacro drmacro Awaiting requested review from drmacro

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@larsga @drmacro @ekimbernow @contrext