-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversion errors with tables #109
Comments
The issue as far as I can tell is that Word expects an empty paragraph following a nested table. If I let Word repair the test doc, it adds an empty paragraph after the table within the cell. Removing that paragraph makes the doc corrupted, restoring makes it open normally. |
Confirmed that if I create a nested table manually in Word it adds a trailing empty paragraph. I don't see anything in the OOXML docs that suggest this is required but it seems to be how Word works. |
See #110 |
The cause of the problem (found by narrowing down the failing example) is empty table cells in the input. With the old code these output:
With the new code they output:
Clearly Word doesn't accept the absence of a paragraph there. |
Fixed here: #137 |
…s with <p> Signed-off-by: eliot.kimber <eliot.kimber@servicenow.com>
…s with <p> Signed-off-by: eliot.kimber <eliot.kimber@servicenow.com>
* Fixes #133, #105: Set compatibity mode setting to turn off compatibility mode. Signed-off-by: eliot.kimber <eliot.kimber@servicenow.com> * Fixes #109: Incorporate fix from Lars Marius to ensure table cell ends with <p> Signed-off-by: eliot.kimber <eliot.kimber@servicenow.com> * WIP: Added multi-section test cases from Lars Marius Signed-off-by: eliot.kimber <eliot.kimber@servicenow.com> * Fixes #117: Last section handling from Lars Marius Signed-off-by: eliot.kimber <eliot.kimber@servicenow.com> --------- Signed-off-by: eliot.kimber <eliot.kimber@servicenow.com>
With the changes in PR #108 Word starts complaining about tables, and has to repair converted Word documents. The error reporting looks like this:
The user reports that "Interestingly, the new tables look better than the old because it seems my border control is being respected by the new JAR ... unless, perhaps, that is related to why Word seems to find the tables in error."
Very likely this is caused by the new code that traverses the contents of the table cell, or perhaps by differences in how garbage content added by POI is deleted.
The text was updated successfully, but these errors were encountered: