Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributing instructions #143

Merged
merged 23 commits into from
Apr 11, 2022
Merged

Add contributing instructions #143

merged 23 commits into from
Apr 11, 2022

Conversation

ejm714
Copy link
Contributor

@ejm714 ejm714 commented Mar 29, 2022

Supersedes #139 to create simpler contributing instructions in light of the incoming changes from #141 which will not require contributors to run make build to generate and commit the rendered markdown files.

Notable changes:

  • Removes the need to file an issue and getting community up votes before making a change to the checklist given this process has not been followed previously and we have not seen any flame wars to date. Relevant discussions have been happening in the PRs themselves which seems sufficient.

If this is approved:

@ejm714 ejm714 mentioned this pull request Mar 29, 2022
7 tasks
@ejm714 ejm714 requested review from jayqi and pjbull March 29, 2022 17:32
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #143 (ee3ee37) into main (3907956) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #143   +/-   ##
=======================================
  Coverage   96.80%   96.80%           
=======================================
  Files           6        6           
  Lines         188      188           
=======================================
  Hits          182      182           
  Misses          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3907956...ee3ee37. Read the comment docs.

@ejm714 ejm714 requested a review from glipstein March 29, 2022 23:17
Copy link
Contributor

@glipstein glipstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌

ejm714 and others added 6 commits April 11, 2022 14:18
Co-authored-by: glipstein <gregory.lipstein@gmail.com>
Co-authored-by: glipstein <gregory.lipstein@gmail.com>
@ejm714 ejm714 merged commit 5f7821b into main Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants