-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pre-commit hook and build docs and examples in GH actions #141
Conversation
Codecov Report
@@ Coverage Diff @@
## main #141 +/- ##
=======================================
Coverage 96.80% 96.80%
=======================================
Files 6 6
Lines 188 188
=======================================
Hits 182 182
Misses 6 6 Continue to review full report at Codecov.
|
8615756
to
16d8f9a
Compare
Design considerations that I'd like feedback on:
|
An alternative approach is that we generate the |
7de1453
to
a65ef40
Compare
f676c14
to
fe4afe1
Compare
I like this approach and updated this PR accordingly. Ready for a review, the current tests are failing due to what appears to be a rate limiting issue with codecov. I'll re-run the tests a little later, a bunch of runs were done earlier today with the backlog after the downtime in GH actions |
@jayqi I've confirmed that the netlify pipeline builds the docs so changes get shown in the netlify preview on the PR (this is how it was already set). I've run a test to confirm changes to the yaml show up on the homepage and examples table. The rendered checklists in varying formats which Let me know if there's anything else needed on this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for getting all of this done.
Right now to make a contribution, a user needs to install the requirements and run
make build
which will re-create the example from the updated yml files. It seems preferable to let users just change the relevant.yml
files (example table and/or checklist one) and then have the GH actions workflow runmake docs
andmake examples
and commit the changed filed. These will be the updated examples here: https://github.com/drivendataorg/deon/tree/main/examples plus the README which is rendered from a template that uses the checklist yml.This PR also removes the pre-commit hook which is duplicative now that we use the GH actions workflow.
Example commit showing the files that get added: 8615756
Note: this action means that after a user opens their PR, they will need to run
git pull
orgit push -f
for any changes they make since the GH action will change the files on the remote branch.