Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created more detailed contributing.md #139

Closed
wants to merge 1 commit into from

Conversation

IshaShah27
Copy link
Contributor

@IshaShah27 IshaShah27 commented Mar 7, 2022

#89

Used old instructions from the readme, a quick chat with Emily, and Peter's guide to adding to example tables to create CONTRIBUTING.md:

  • instructions on how to add an item to the checklist
  • instructions on how to add an example (taken from Peter's entry in the wiki)
  • instructions how to prepare submissions (make build)
  • instructions on what to submit in a PR
  • review content of CONTRIBUTING.md - instructions and conventions (e.g., the part where it says an addition to the checklist must have 10 upvotes from community)
  • remove redundant/outdated material from README.md
  • link properly to CONTRIBUTING.md from the "Changing the checklist" section and the "Where things have gone wrong" section

@IshaShah27 IshaShah27 marked this pull request as draft March 7, 2022 18:26
@IshaShah27 IshaShah27 requested a review from ejm714 March 7, 2022 18:26
@IshaShah27 IshaShah27 self-assigned this Mar 7, 2022
@IshaShah27 IshaShah27 requested a review from jayqi March 7, 2022 18:27
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #139 (4a4f05b) into main (0ad8fec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   96.80%   96.80%           
=======================================
  Files           6        6           
  Lines         188      188           
=======================================
  Hits          182      182           
  Misses          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ad8fec...4a4f05b. Read the comment docs.

@ejm714 ejm714 mentioned this pull request Mar 29, 2022
2 tasks
@ejm714
Copy link
Contributor

ejm714 commented Mar 29, 2022

Thanks for this draft @IshaShah27. I've integrated and simplified this in #143

@ejm714 ejm714 closed this Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants