Guild embed was renamed to widget #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taarek
reviewed
Apr 22, 2020
docs/resources/Guild.md
Outdated
| @@ -19,8 +19,8 @@ Guilds in Discord represent an isolated collection of users and channels, and ar | |||
| | region | string | [voice region](#DOCS_RESOURCES_VOICE/voice-region-object) id for the guild | | |||
| | afk_channel_id | ?snowflake | id of afk channel | | |||
| | afk_timeout | integer | afk timeout in seconds | | |||
| | embed_enabled? | boolean | whether this guild is embeddable (e.g. widget) | | |||
| | embed_channel_id? | ?snowflake | if not null, the channel id that the widget will generate an invite to | | |||
| | embed_enabled? | boolean | whether or not the server widget is enabled (deprecated, replaced with widget_enabled) | | |||
There was a problem hiding this comment.
I know it was server before as well. But shouldn't guild be preferred? Considering this is a guild object structure and not a server object structure. Maybe a nitpick.
Otherwise looks ok.
There was a problem hiding this comment.
They're referred to as servers in many other parts of this page too
There was a problem hiding this comment.
I guess it should be fixed in a separate PR. It's just annoying with all these inconsistency
This was referenced May 13, 2020
Erk-
added a commit
to Erk-/twilight
that referenced
this pull request
May 27, 2020
discord/discord-api-docs#1536 Signed-off-by: Valdemar Erk <valdemar@erk.io>
Erk-
added a commit
to Erk-/twilight
that referenced
this pull request
May 27, 2020
discord/discord-api-docs#1536 Signed-off-by: Valdemar Erk <valdemar@erk.io>
Erk-
added a commit
to twilight-rs/twilight
that referenced
this pull request
May 28, 2020
* Update the model with the newest changes. - Document optional Connection object fields. discord/discord-api-docs#1466 - Update invite create event fields and example invite object. discord/discord-api-docs#1438 - New member count fields on get guilds discord/discord-api-docs#1528 - Add support for `include_roles` when pruning. discord/discord-api-docs#1563 - Add `max_video_channel_users` to guilds. discord/discord-api-docs#1512 - Rename guild embed to guild widget. discord/discord-api-docs#1536 Signed-off-by: Valdemar Erk <valdemar@erk.io>
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates widget/embed stuff in the Guild page according to my discussion with night in Discord Developers