-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecate GuildEmbed methods and properties in favour of GuildWidget #4121
Conversation
My relevant upstream API docs PR has been merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small nits about the @deprecated
annotations.
The deprecated guild embed properties and endpoints are removed in API v8. |
just realized, would it be a good idea to document the replacements in the descriptions? |
We did not do that in the past. |
Please describe the changes this PR makes and why it should be merged:
This PR deprecates all of the methods and properties relating to
GuildEmbed
as its deprecated from the API (see discord/discord-api-docs#1536), and adds in new methodsfetchWidget
andsetWidget
I wasn't sure whether to change the existing methods to use the
widget
endpoint since the methods are deprecated, the new methods should instead be used (although it will eventually lead to the old methods breaking)I also thought it better to rename the existing typedefs (as that's not breaking since the return types are still the same) instead of making duplicate typedefs
Status
Semantic versioning classification: