Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 27eea4f, guild fields #1539

Merged
merged 2 commits into from May 11, 2020
Merged

Fix for 27eea4f, guild fields #1539

merged 2 commits into from May 11, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 22, 2020

  • Fixed missing ? for optional Guild#approximate_member_count
  • Documented a new field that Mason put in an example somewhere:
    Guild#max_video_channel_users. I assume this is optional, but I
    am not sure of the exact situations; I assume it will not be null
    though.
  • changed Guild#permissions to say "excludes overwrites" instead of
    mentioning channels specifically. Partially did this because I just spent
    10 minutes reformatting the table and didn't want to do it again;
    partially did this because it would not be sensible for it to take into
    account per-channel user-specific overwrites.
  • updated wording to refer to guilds as guilds consistently
  • updated to indicate "PUBLIC" guilds refers to the "PUBLIC" feature.
  • changed approximate_presence_count to refer to members as non-offline
    as this also includes members in DND and idle, and it prevents
    being ambiguous or implying some relation to the status terminology
    and enumerations.
  • documented that widget fields are null if not present
  • documented that the guild embed is also known as the widget
  • other consistency stuff

Hoping this will make stuff a bit more consistent as well to prevent the number of questions that new developers have :)

- Fixed missing `?` for optional `Guild#approximate_member_count`
- Documented a new field that Mason put in an example somewhere: 
    `Guild#max_video_channel_users`. I assume this is optional, but I
    am not sure of the exact situations; I assume it will not be `null` 
    though.
- changed `Guild#permissions` to say "excludes overwrites" instead of
    mentioning channels specifically. Partially did this because I just spent
    10 minutes reformatting the table and didn't want to do it again; 
    partially did this because it would not be sensible for it to take into
    account per-channel user-specific overwrites.
- updated wording to refer to guilds as `guilds` consistently
- updated to indicate "PUBLIC" guilds refers to the "PUBLIC" feature.
- changed `approximate_presence_count` to refer to members as `non-offline`
   as this also includes members in DND and idle, and it prevents 
   being ambiguous or implying some relation to the `status` terminology
   and enumerations.
- documented that widget fields are null if not present
- documented that the guild embed is _also known as_ the widget
- other consistency stuff
@advaith1
Copy link
Contributor

Documented a new field that Mason put in an example somewhere:
Guild#max_video_channel_users. I assume this is optional, but I
am not sure of the exact situations; I assume it will not be null
though.

dupe of #1512

@advaith1
Copy link
Contributor

documented that the guild embed is also known as the widget

semi-dupe of #1536 but inaccurate because it was renamed and referring to it as embed is deprecated

@ghost
Copy link
Author

ghost commented Apr 22, 2020

@advaith1 true, I didn't realise that until now. At the risk of sounding like I am being awkward, probably worth merging it here rather than removing it again and then having to fix the merge conflicts in the other issue, which seems to be inactive for the past week

@msciotti
Copy link
Contributor

Looks good if you don't mind fixing the merge conflicts.

@ghost
Copy link
Author

ghost commented May 11, 2020

@msciotti fixed merge conflicts, cheers for pointing that out 👍

@msciotti msciotti merged commit db01f34 into discord:master May 11, 2020
@ghost ghost deleted the patch-3 branch May 11, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants