Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement compiler options #98

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

yacinehmito
Copy link
Contributor

@yacinehmito yacinehmito commented Apr 4, 2023

Since the initial release, the bundle type, the compiler options and the imports were not properly forwarded from JS to Rust.

We now forward them, and added some tests to verify this behavior.

Closes #83.

@yacinehmito
Copy link
Contributor Author

This will be ready once #97 is merged.

@yacinehmito yacinehmito changed the title Forward arguments feat: implement compiler options Apr 25, 2023
Since the initial release, the bundle type, the compiler options and the
imports were not properly forwarded from JS to Rust.

We now forward them, and added some tests to verify this behaviour.

Closes denoland#83, denoland#69, denoland#29.
@yacinehmito yacinehmito marked this pull request as ready for review April 26, 2023 21:01
@yacinehmito
Copy link
Contributor Author

@dsherret This is ready!

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret merged commit 2cfc00f into denoland:main Apr 26, 2023
@yacinehmito yacinehmito deleted the forward-arguments branch April 26, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bundle always has inline source maps even if inlineSources and inlineSourceMap are false
2 participants