Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emit with sourceMaps #69

Closed
cdaringe opened this issue Aug 21, 2022 · 1 comment · Fixed by #113
Closed

emit with sourceMaps #69

cdaringe opened this issue Aug 21, 2022 · 1 comment · Fixed by #113

Comments

@cdaringe
Copy link

Problem

emit used to support sourceMaps. The new API is drastically more constrained than the prior, preventing me from generating mappable src.

Discussion

Can the compiler options be re-exposed back into emit?
@Ciantic
Copy link

Ciantic commented Sep 23, 2022

On latest it's on by default, I'm trying to turn it off.

yacinehmito added a commit to yacinehmito/deno_emit that referenced this issue Apr 4, 2023
@yacinehmito
Forward arguments from JS to Rust
54fceab 
Since the initial release, the bundle type, the compiler options and the
imports were not properly forwarded from JS to Rust.

We now forward them, and added some tests to verify this behaviour.

Closes denoland#83, denoland#69, denoland#29.
@yacinehmito yacinehmito mentioned this issue Apr 4, 2023
Merged
yacinehmito added a commit to yacinehmito/deno_emit that referenced this issue Apr 9, 2023
@yacinehmito
Forward arguments from JS to Rust
c414001 
Since the initial release, the bundle type, the compiler options and the
imports were not properly forwarded from JS to Rust.

We now forward them, and added some tests to verify this behaviour.

Closes denoland#83, denoland#69, denoland#29.
yacinehmito added a commit to yacinehmito/deno_emit that referenced this issue Apr 25, 2023
@yacinehmito
Forward arguments from JS to Rust
4a7a4f5 
Since the initial release, the bundle type, the compiler options and the
imports were not properly forwarded from JS to Rust.

We now forward them, and added some tests to verify this behaviour.

Closes denoland#83, denoland#69, denoland#29.
yacinehmito added a commit to yacinehmito/deno_emit that referenced this issue Apr 26, 2023
@yacinehmito
Forward arguments from JS to Rust
01172ac 
Since the initial release, the bundle type, the compiler options and the
imports were not properly forwarded from JS to Rust.

We now forward them, and added some tests to verify this behaviour.

Closes denoland#83, denoland#69, denoland#29.
dsherret pushed a commit that referenced this issue Apr 26, 2023
@yacinehmito
feat: implement compiler options (#98)
2cfc00f 
Forward arguments from JS to Rust

Since the initial release, the bundle type, the compiler options and the
imports were not properly forwarded from JS to Rust.

We now forward them, and added some tests to verify this behaviour.

Closes #83, #69, #29.
@yacinehmito yacinehmito mentioned this issue May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implement compiler options for transpile yacinehmito/deno_emit
2 participants
@Ciantic @cdaringe