Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement compiler options for transpile #113

Merged
merged 1 commit into from
May 3, 2023
Merged

feat: implement compiler options for transpile #113

merged 1 commit into from
May 3, 2023

Conversation

yacinehmito
Copy link
Contributor

PR #98 forwarded compiler options from JS to Rust only for the bundle function. This PR also implements this for the transpile function.

The tests related to source map have been made common to bundle and transpile, but set to their own file.

Closes #69.
Closes #29.

@yacinehmito yacinehmito force-pushed the compiler-options-transpile branch 2 times, most recently from af8d4bb to e7f1e6d Compare May 3, 2023 17:46
@yacinehmito yacinehmito marked this pull request as ready for review May 3, 2023 17:46
@yacinehmito yacinehmito force-pushed the compiler-options-transpile branch 2 times, most recently from 8fd162d to d30a15d Compare May 3, 2023 18:12
@yacinehmito yacinehmito force-pushed the compiler-options-transpile branch from d30a15d to 6cc0275 Compare May 3, 2023 18:15
dsherret
dsherret approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great again. Thanks!

@dsherret dsherret merged commit 6d21e97 into denoland:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

emit with sourceMaps Implement compiler options
2 participants
@yacinehmito @dsherret