Use symbols for polymorphic route arguments in Scope Type admin

[tramuntanal]

🎩 What? Why?

Please describe your pull request.
Scope Type admin is crashing due to the use of strings for polymorphic route arguments in Scope type related admin views.

ActionView::Template::Error (Please use symbols for polymorphic route arguments.):
    1: <div class="card">
    2:   <div class="card-divider">
    3:     <% if allowed_to? :creste, :scope_type %>
    4:       <h2 class="card-title"><%= t "decidim.admin.titles.scope_types" %> <%= link_to t("actions.add", scope: "decidim.admin"), ["new", "scope_type"], class: "button tiny button--title" %></h2>
    5:     <% end %>
    6:   </div>
    7:   <div class="card-section">
  
actionpack (5.2.6) lib/action_dispatch/routing/polymorphic_routes.rb:296:in `block in handle_list'
actionpack (5.2.6) lib/action_dispatch/routing/polymorphic_routes.rb:291:in `map'
actionpack (5.2.6) lib/action_dispatch/routing/polymorphic_routes.rb:291:in `handle_list'
actionpack (5.2.6) lib/action_dispatch/routing/polymorphic_routes.rb:219:in `polymorphic_method'
actionpack (5.2.6) lib/action_dispatch/routing/polymorphic_routes.rb:140:in `polymorphic_path'
actionview (5.2.6) lib/action_view/routing_url_for.rb:103:in `url_for'
actionview (5.2.6) lib/action_view/helpers/url_helper.rb:202:in `link_to'
/home/oliver/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/decidim-70444b614758/decidim-admin/app/views/decidim/admin/scope_types/index.html.erb:4:in `__home_oliver__rbenv_versions_______lib_ruby_gems_______bundler_gems_decidim______b_______decidim_admin_app_views_decidim_admin_scope_types_index_html_erb___4149322209680745505_245540'

📌 Related Issues

Link your PR to an issue

• Fixes Rails 6.0.3.7 Regression - Please use symbols for polymorphic route arguments. #8021

Testing

Describe the best way to test or validate your PR.
As an admin, I should be able to manage scope types.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

• ❓ CONSIDER adding a unit test if your PR resolves an issue.
• ✔️ DO check open PR's to avoid duplicates.
• ✔️ DO keep pull requests small so they can be easily reviewed.
• ✔️ DO build locally before pushing.
• ✔️ DO make sure tests pass.
• ✔️ DO make sure any new changes are documented in docs/.
• ✔️ DO add and modify seeds if necessary.
• ✔️ DO add CHANGELOG upgrade notes if required.
• ✔️ DO add to GraphQL API if there are new public fields.
• ✔️ DO add link to MetaDecidim if it's a new feature.
• ❌AVOID breaking the continuous integration build.
• ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing

♥️ Thank you!

[tramuntanal]

Hi @leio10 the failing test is due to

npm ERR! code ECONNRESET
npm ERR! network aborted
npm ERR! network This is a problem related to network connectivity.

can you re-run it please?

[leio10]

Nice catch!

[mrcasals]

It's worth noting that we need to add some system tests to this page. This failing means we don't have any test there :(