Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scope types admin #8149

Merged
merged 2 commits into from
Jun 21, 2021
Merged

Fix scope types admin #8149

merged 2 commits into from
Jun 21, 2021

Conversation

armandfardeau
Copy link
Contributor

@armandfardeau armandfardeau commented Jun 21, 2021 •
edited
Loading

🎩 What? Why?

Backport #8052 and #8053

📌 Related Issues

Link your PR to an issue

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

@armandfardeau armandfardeau marked this pull request as ready for review June 21, 2021 15:23
@leio10 leio10 added backport Pull Requests that are a backport for a fixed bug in-review module: admin type: fix PRs that implement a fix for a bug labels Jun 21, 2021
@leio10 leio10 changed the title Backport/fix/scope types admin Fix scope types admin Jun 21, 2021
@leio10 leio10 merged commit 81a3ea3 into decidim:release/0.23-stable Jun 21, 2021
jkraemer pushed a commit to ElectricThings/decidim that referenced this pull request Nov 26, 2021
@armandfardeau @tramuntanal
@leio10 @jkraemer
Fix scope types admin (decidim#8149)
9cc0889 
Co-authored-by: Oliver Valls <199462+tramuntanal@users.noreply.github.com>
Co-authored-by: leio10 <leiodd@gmail.com>
jkraemer pushed a commit to ElectricThings/decidim that referenced this pull request Nov 26, 2021
@armandfardeau @tramuntanal
@leio10 @jkraemer
Fix scope types admin (decidim#8149)
6ae5ce8 
Co-authored-by: Oliver Valls <199462+tramuntanal@users.noreply.github.com>
Co-authored-by: leio10 <leiodd@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leio10 leio10 leio10 approved these changes

Assignees
No one assigned
Labels
backport Pull Requests that are a backport for a fixed bug in-review module: admin type: fix PRs that implement a fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@armandfardeau @leio10 @tramuntanal