Fix attachment title migration generating possibly invalid values #8020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahukkanen
added a commit
to mainio/decidim
that referenced
this pull request
May 24, 2021
12 tasks
ahukkanen
added a commit
to mainio/decidim
that referenced
this pull request
May 24, 2021
12 tasks
leio10
pushed a commit
that referenced
this pull request
May 24, 2021
entantoencuanto
added a commit
that referenced
this pull request
May 31, 2021
* develop: (59 commits) Update supported versions in docs (#8079) Meetings merge minutes and close actions (#7968) Meeting calendars providers (#7944) Fix broken test on meetings after merging PR without rebase (#8076) Show participants list in meetings (#7933) Security feature external link warning (#7397) Add missing tests for scope types admin page (#8053) Use symbols for polymorphic route arguments (#8052) Mockup design for Participation statistics tables in Votings (#7879) Fix boolean fields for .reported? and .hidden? which is nil if no report exists (#7990) Fix redirects broken by Terms and Conditions redirect (#8036) Amend CSS overwritting (#8007) New Crowdin updates (#8048) Fix undetected broken tests because of missing dependencies (#8050) Validate results by Monitoring Committee Members (#7899) Electoral certificate validation by Monitoring Committee Members (#7871) Publish and unpublish a meeting (#7893) New Crowdin updates (#8005) Polling station closure attach the physical electoral closure certificate (#7929) Fix attachment title migration generating possibly invalid values (#8020) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The
FixAttachmentsTitlesmigration creates possibly duplicate title hashes.The problem is that sometimes the
titlefield is already a hash but thedescriptionfield can still be anil(i.e. not a hash).This causes the following check in the migration to proceed with the migration:
decidim/decidim-participatory_processes/db/migrate/20201006072346_fix_attachments_titles.rb
Line 9 in d3b88af
This fixes the migration by ensuring that if the title or the description are already hashes, those columns won't be updated. If one of them is a hash and one of them is not, the migration will run for the column that does not have a hash.
📌 Related Issues
Testing
titlefield being a translation hash and thedescriptionfield beingnil📋 Checklist
docs/.