Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: 24-10-24 (v39) #2582

Merged
merged 16 commits into from
Oct 24, 2024
Merged

release: 24-10-24 (v39) #2582

merged 16 commits into from
Oct 24, 2024

Conversation

aixaCode
Copy link
Collaborator

What does this PR change?

Release v.039

How to test the changes?

  1. Launch the explorer
  2. ...

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

fcolarich and others added 16 commits October 22, 2024 11:23
@fcolarich
fix: tweaked cursor values so they properly align with real cursor (#…
c47a5f3 
…2526)
@github-actions @m3taphysics @aixaCode
chore: sync main to dev (#2531)
39754cd 
Signed-off-by: Ashley Canning <ashley.canning@decentraland.org>
Co-authored-by: Ashley Canning <ashley.canning@decentraland.org>
Co-authored-by: Aga <aga@besz.me>
@pravusjif
fix: unreliable 'playing' video event (#2474)
2c9df4c
@davidejensen
Fix: avoid movement blocking to affect when closing emoji search (#2529)
72c08f0
@popuz
Fix: zero lookAt rotation in multiplayer (#2540)
1e3a49a 
## What does this PR change?
additional check for zero vector

doesn't produces spikes anymore
![image](https://github.com/user-attachments/assets/c75188ca-4eec-492c-943c-c12fc25eed45)

## How to test the changes?
just fast smoke test
@davidejensen
fix: removed rich text from chat (#2544)
59f0c41
@QThund
fix: The outline of text shapes is wrong when created (#2537)
12012c7 
When the cached TextMeshPro instances were reused and the new outline width equaled zero, it tried to disable the outline shader keyword which does not exist in the shader (so the previous values related to outline stayed the same and were still used). Now it also resets the values of the related properties.
@dalkia
fix: Asset bundle material leak (LOD) (#2533)
e781f90
@lorux0
fix: unequip force render (#2525)
9519982
@popuz
temporarly disable performance analytics (#2546)
3657360
@dalkia
fix: Connect to fake room (#2542)
d29bd1b
@pravusjif
fix: raw gltf external dependencies deeper path (#2541)
46f8d7b
@popuz
Fix:performance analytics spikes (#2569)
a9e1570
@fcolarich
fix: scenes not switching to LOD properly. (#2572)
2e697f2 
* Fix for candidate state check

* Added additional check
@dalkia
fix: Scene was not initializing correctly (#2581)
4d1a16c
@aixaCode
fix: wrong tag version on dev (#2580)
9ad45d5
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 24, 2024 •
edited
Loading

badge

Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.

Name Link
Commit 9ad45d5
Logs https://github.com/decentraland/unity-explorer/actions/runs/11498074612
Download Windows https://github.com/decentraland/unity-explorer/suites/30038637108/artifacts/2098595028
Download Windows S3 https://explorer-artifacts.decentraland.org/@dcl/unity-explorer/branch/dev/Decentraland_windows64.zip
Download Mac https://github.com/decentraland/unity-explorer/suites/30038637108/artifacts/2098663209
Download Mac S3 https://explorer-artifacts.decentraland.org/@dcl/unity-explorer/branch/dev/Decentraland_macos.zip
Built on 2024-10-24T12:00:13Z

anicalbano
anicalbano approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@anicalbano anicalbano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Sanity check and smoke performed on Windows and working as expected. Besides our Smoke Test guide https://www.notion.so/decentraland/Smoke-Test-Alpha-1055f41146a58020a624e86a564d60a1 there was also checks for:

✔️ Create new account
✔️Pass through the onboarding
✔️Receive the emotes and wearables
✔️Get the notifications
✔️Get the Decentraland Citizen Badge
✔️Avatar personalization
✔️Minigames testing

Ludmilafantaniella
Ludmilafantaniella approved these changes Oct 24, 2024
View reviewed changes
Copy link

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Sanity check and smoke performed on Mac and working as expected. https://www.notion.so/decentraland/Smoke-Test-Alpha-1055f41146a58020a624e86a564d60a1 there was also checks for:

  • Daily Quest
  • Minigames (Tower of Hanoi, Tile Tally, Word Search)

@aixaCode aixaCode added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 81ee33e Oct 24, 2024
55 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ludmilafantaniella Ludmilafantaniella Ludmilafantaniella approved these changes

@anicalbano anicalbano anicalbano approved these changes

@dalkia dalkia Awaiting requested review from dalkia

@QThund QThund Awaiting requested review from QThund

Assignees

@aixaCode aixaCode

Labels
release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@aixaCode @anicalbano @Ludmilafantaniella @fcolarich @pravusjif @davidejensen @popuz @QThund @dalkia @lorux0