Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: avoid movement blocking to affect when closing emoji search #2529

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

davidejensen
Copy link
Member

@davidejensen davidejensen commented Oct 22, 2024

What does this PR change?

Fix #2527 (maybe also fixed #2477 )
Removes the input blocker management from the emoji panel as it's handled by the chat controller already

...

How to test the changes?

  1. Launch the explorer
  2. Search for an emoji in the chat.
  3. Exit the emoji search using 'Esc', then the 'X' button, or by clicking outside the chat.
  4. Try to move the avatar or use hotkeys like U, B, N, M, I.

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copy link
Contributor

@fcolarich fcolarich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! the chat was a nightmare of input blocks overriding each other xDDD

@DafGreco DafGreco self-requested a review October 22, 2024 09:32
Copy link

@DafGreco DafGreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix implemented on both Platforms :

Sanity check performed :

  • Teleport
    -Quests
    -Backpack
    -Emotes
    -Notifications

@davidejensen davidejensen merged commit 72c08f0 into dev Oct 22, 2024
6 checks passed
@davidejensen davidejensen deleted the fix/input-blocking-emoji-search branch October 22, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants