-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: performance analytics spikes #2569
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below. |
…' into fix/performance-analytics-spikes
Ludmilafantaniella
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Fix verified on Windows and Mac. The explorer run as a charm, no new issues were found during the smoke testing:
- Social interaction (Passport - chat)
- Multiplyer (wearables and emotes)
- Backpack functiuonality
- World: metadynelabs
- Minigames: whack frog, color pop
- Side bar (all shortcuts)
dalkia
approved these changes
Oct 24, 2024
popuz
changed the title
Fix/performance analytics spikes
Fix: performance analytics spikes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Fix #2534
JsHeap
(until we find the solution for it)Sort()
and calculation ofFrameTime
samples, instead of one frame to do it inUpdate
Sort() optimization:
11 ms (90 fps) - 1364 frames
20 ms (50 fps) - 750 frames
40 ms (25 fps) - 375 frames
How to test the changes?
Just a smoke test
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md