fix tenant glob match bug #128
Merged
+121
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Jin <yi.jin@databricks.com>
2916968 to
7913f6d
Compare
Signed-off-by: Yi Jin <yi.jin@databricks.com>
I cannot reproduce chromedp panics locally so trying to see if a newer Ubuntu version would help. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Signed-off-by: Yi Jin <yi.jin@databricks.com>
68875be to
e99f22f
Compare
Fixing E2E tests using headless Chrome
yuchen-db
approved these changes
Feb 14, 2025
hczhu-db
reviewed
Feb 15, 2025
Comment on lines
+1264
to
+1268
| opts := append(chromedp.DefaultExecAllocatorOptions[:], | ||
| chromedp.Flag("headless", true), | ||
| chromedp.Flag("no-sandbox", true), | ||
| chromedp.Flag("disable-gpu", true), | ||
| ) |
There was a problem hiding this comment.
Does this change fix the flaky end-to-end test? How did you figure out those flags are needed?
| // Fast path for the common case of direct match. | ||
| if mt, ok := t[tenant]; ok && isExactMatcher(mt) { | ||
| return true, nil | ||
| } else { |
There was a problem hiding this comment.
nit: don't need the else branch.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug when tenant glob match have multiple glob pattern, the match will iterate until the end and never break when first match = true. This can be verified with unit test "glob hashring multiple matches"
Also submit a fix to upstream: thanos-io#8107
Also fixed mis spell as well as e2e test by cherry picking thanos-io#8005
Changes
Verification