[Issue-8106] Fix tenant hashring glob with multiple tenant match patterns #8107
+90
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Jin <yi.jin@databricks.com>
jnyi
commented
Feb 14, 2025
| if err != nil { | ||
| return false, fmt.Errorf("error matching tenant pattern %s (tenant %s): %w", tenantPattern, tenant, err) | ||
| } | ||
| if matches { |
There was a problem hiding this comment.
should short circuit when a match is found, old code will continue and ignore previous matched pattern
2 tasks
GiedriusS
approved these changes
Feb 20, 2025
neevnuv
pushed a commit
to neevnuv/thanos
that referenced
this pull request
Feb 20, 2025
…hanos-io#8107) Signed-off-by: Yi Jin <yi.jin@databricks.com> Signed-off-by: neevnuv <neevnuv@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #8106
Without this change, unit test "glob hashring multiple matches" will fail
it passes after the fix
Changes
Verification