receiver: Add hot reload for relabel configs #124
Conversation
| @@ -143,14 +137,6 @@ func NewLimiterWithOptions( | |||
| Help: "How many times the limit configuration failed to reload.", | |||
| }, | |||
| ) | |||
| limiter.configReloadFailedCounter = promauto.With(limiter.registerer).NewCounter( | |||
There was a problem hiding this comment.
Removed because this is present twice here (see line 138 just above)
There was a problem hiding this comment.
left a few comments, please test the branch following this https://databricks.atlassian.net/wiki/spaces/UN/pages/3754591684/Pantheon+knowledge+base#Testing-Guide
| TSDBStats: dbs, | ||
| Limiter: limiter, | ||
|
|
||
| Writer: writer, |
There was a problem hiding this comment.
nit: no change happens here right?
There was a problem hiding this comment.
yes only whitespace changes by gofmt that does some kind of alignment of the fields.
cmd/thanos/receive.go
Outdated
| @@ -1073,6 +1086,8 @@ func (rc *receiveConfig) registerFlag(cmd extkingpin.FlagClause) { | |||
| rc.maxBackoff = extkingpin.ModelDuration(cmd.Flag("receive-forward-max-backoff", "Maximum backoff for each forward fan-out request").Default("5s").Hidden()) | |||
|
|
|||
| rc.relabelConfigPath = extflag.RegisterPathOrContent(cmd, "receive.relabel-config", "YAML file that contains relabeling configuration.", extflag.WithEnvSubstitution()) | |||
| cmd.Flag("receive.relabel-config-reload-timer", "Minimum amount of time to pass for the relabel configuration to be reloaded. Helps to avoid excessive reloads."). | |||
| Default("1s").Hidden().DurationVar(&rc.relabelConfigReloadTimer) | |||
There was a problem hiding this comment.
default 1s could be excessive, let's do 5m for default, i assume the relabel config should not change that frequently.
There was a problem hiding this comment.
+1
Can we have a default value that disables this feature?
There was a problem hiding this comment.
Ok. I went by the same value as for the limiters config file that is reloaded every 1s by default.
Line 1159 in 779d964
There was a problem hiding this comment.
Changed default to 0 with the semantics of disabling the feature.
| testutil.Ok(t, err) | ||
|
|
||
| // Rewrite the relabels file in temp with an invalid file, should not update the config. | ||
| testutil.Ok(t, relabelFile.Rewrite(invalidRelabels)) |
There was a problem hiding this comment.
how do we know the invalid relabels are not picked up
There was a problem hiding this comment.
There is an assert below on line 56 that the value is the same as origRelabelsConfig.
cmd/thanos/receive.go
Outdated
| @@ -1073,6 +1086,8 @@ func (rc *receiveConfig) registerFlag(cmd extkingpin.FlagClause) { | |||
| rc.maxBackoff = extkingpin.ModelDuration(cmd.Flag("receive-forward-max-backoff", "Maximum backoff for each forward fan-out request").Default("5s").Hidden()) | |||
|
|
|||
| rc.relabelConfigPath = extflag.RegisterPathOrContent(cmd, "receive.relabel-config", "YAML file that contains relabeling configuration.", extflag.WithEnvSubstitution()) | |||
| cmd.Flag("receive.relabel-config-reload-timer", "Minimum amount of time to pass for the relabel configuration to be reloaded. Helps to avoid excessive reloads."). | |||
| Default("1s").Hidden().DurationVar(&rc.relabelConfigReloadTimer) | |||
There was a problem hiding this comment.
+1
Can we have a default value that disables this feature?
0741201 to
7f4a0b9
Compare
7f4a0b9 to
e6fcd04
Compare
Changes
Verification