Handle timeouts in BrowserClient #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove stale [docs] link. Closes dart-lang#3
Copy components from shelf
Enable pub run test
Merge 0.11.x branch
In the example, `Client` and `BaseClient` are package qualified, but `BaseRequest` and `StreamedResponse` aren't.
At this point, we're only using this for Chain.current which might as well just be StackTrace.current.
|
What's the benefit to exposing this as a client-specific context variable rather than providing client-agnostic middleware? |
|
The functionality is already built-in with the web platform in this case. A client middleware could use configuration specific imports to choose either the |
|
What's the benefit of using the built-in behavior, though?
I don't understand. How would it know what the implementation of the root-level client is? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
HttpRequest.timeoutas well as catching the timeout event.Closes #21 at least for
BrowserClient.