Adding client tests #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nex3 this adds the tests but some tests fail. On the
On the
For both
Anyways I'd like to land this and fix the issues individually. @kevmoo that means that tests will be failing until the above is resolved. |
nex3
suggested changes
Jun 23, 2017
test/client_test.dart
Outdated
| serverUrl = Uri.parse(await channel.stream.first); | ||
| }); | ||
|
|
||
| // HEAD |
There was a problem hiding this comment.
These headers seem redundant with the groups.
test/client_test.dart
Outdated
| }); | ||
|
|
||
| test('readBytes throws an error for a 4** status code', () { | ||
| platformClient().readBytes(serverUrl.resolve('/error')).then((_) { |
There was a problem hiding this comment.
Is there a specific way I should be using one of the expect functions? I wasn't able to get it to work otherwise.
test/hybrid/client.dart
Outdated
| @@ -0,0 +1,9 @@ | |||
| // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file | |||
There was a problem hiding this comment.
I don't understand why this is under a "hybrid" directory.
test/hybrid/server.dart
Outdated
| 'host', | ||
| ]; | ||
|
|
||
| hybridMain(StreamChannel channel) async { |
There was a problem hiding this comment.
Document this. In particular, mention which tests it's used in and what the server does.
nex3
approved these changes
Jun 23, 2017
test/client_test.dart
Outdated
| }); | ||
|
|
||
| test('readBytes throws an error for a 4** status code', () { | ||
| platformClient().readBytes(serverUrl.resolve('/error')).then((_) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
dart:htmlanddart:iocompatibleClienttest. A server is added for the clients to call.