Add content type library #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
suggested changes
Oct 19, 2017
lib/src/content_type.dart
Outdated
| /// | ||
| /// Returns [fallback] if [charset] is null or if no [Encoding] was found that | ||
| /// corresponds to [charset]. | ||
| Encoding encodingForCharset(String charset, [Encoding fallback = LATIN1]) { |
There was a problem hiding this comment.
Now that we have ??, it's probably simpler to just return null if the encoding isn't found rather than having fallback parameters.
lib/src/content_type.dart
Outdated
| } | ||
|
|
||
| /// Modifies the media [type]'s [encoding]. | ||
| MediaType modifyEncoding(MediaType type, Encoding encoding) => |
There was a problem hiding this comment.
This doesn't seem to be used anywhere, and I'm not sure it would be worth factoring out even if it were...
There was a problem hiding this comment.
I was going to use it when creating the content-type header from a body and also its in the multipart stuff.
There was a problem hiding this comment.
It just doesn't seem like it provides substantial value over just inlining the definition.
lib/src/message.dart
Outdated
| return _contentLengthCache; | ||
| var contentLengthHeader = getHeader(headers, 'content-length'); | ||
| if (contentLengthHeader == null) return null; | ||
| return _contentLengthCache = int.parse(contentLengthHeader); |
There was a problem hiding this comment.
We generally avoid using the return value of assignment expressions.
nex3
approved these changes
Oct 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate content-type related code into a single library and start using it within
Message.