Script for docker install instead of actions-setup-docker #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## master #986 +/- ##
=======================================
Coverage 21.71% 21.71%
=======================================
Files 33 33
Lines 1920 1920
=======================================
Hits 417 417
Misses 1449 1449
Partials 54 54 Continue to review full report at Codecov.
|
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
shubham1172
approved these changes
May 26, 2022
There was a problem hiding this comment.
LGTM based on docker/for-mac#2359 (comment) and our testing with quickstarts/pipelines.
mukundansundar
approved these changes
May 31, 2022
hueifeng
pushed a commit
to hueifeng/cli
that referenced
this pull request
Jun 3, 2022
* Script for docker install instead of actions-setup-docker Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * trigger pr checks Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Signed-off-by: HueiFeng <695979933@qq.com>
mukundansundar
pushed a commit
that referenced
this pull request
Jun 9, 2022
* Modify path DaprRoot add the SystemDrive environment variable Signed-off-by: HueiFeng <695979933@qq.com> * Script for docker install instead of actions-setup-docker (#986) * Script for docker install instead of actions-setup-docker Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * trigger pr checks Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Signed-off-by: HueiFeng <695979933@qq.com> * Format output of dapr --version as JSON. (#878) * Format output of dapr --version as JSON. Signed-off-by: fanfanbj <fanfanbj@outlook.com> * Format output of dapr --version as JSON. Signed-off-by: fanfanbj <fanfanbj@outlook.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: HueiFeng <695979933@qq.com> * Fix for panic during upgrade of edge version dapr (#983) * Fix for panic during upgrade of edge version dapr Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * change console log message Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: HueiFeng <695979933@qq.com> * Add dapr annotate command (#873) * Add dapr inject command Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Add additional opts Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Update comment regarding injection Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix some linting issues (more to go) Signed-off-by: Joni Collinge <jonathancollinge@live.com> * use existing const in tests Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix some more linting Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix some more linting Signed-off-by: Joni Collinge <jonathancollinge@live.com> * udpate tests Signed-off-by: Joni Collinge <jonathancollinge@live.com> * udpate tests Signed-off-by: Joni Collinge <jonathancollinge@live.com> * add option to run against a URL Signed-off-by: Joni Collinge <jonathancollinge@live.com> * refactor cmd/inject.go slightly Signed-off-by: Joni Collinge <jonathancollinge@live.com> * update example text Signed-off-by: Joni Collinge <jonathancollinge@live.com> * autogenerate appid if not present Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Update comment Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Add support for target namespace Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Update comment Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Add warning about app id generation to usage Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix linting issues Signed-off-by: Joni Collinge <jonathancollinge@live.com> * rename inject to annotate Signed-off-by: Joni Collinge <jonathancollinge@live.com> * go mod tidy Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix lint Signed-off-by: Joni Collinge <jonathancollinge@live.com> * update --help URL Signed-off-by: Joni Collinge <jonathancollinge@live.com> * add README.md seciton Signed-off-by: Joni Collinge <jonathancollinge@live.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: HueiFeng <695979933@qq.com> * Update go version to 1.18 (#982) * Update go version to 1.18 Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * Bumping golangci-lint Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Signed-off-by: HueiFeng <695979933@qq.com> * adding dapr-http-read-buffer-size parameter to cli Signed-off-by: HueiFeng <695979933@qq.com> Co-authored-by: Pravin Pushkar <ppushkar@microsoft.com> Co-authored-by: FanBin <fanfanbj@outlook.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Co-authored-by: Joni Collinge <jonathancollinge@live.com>
4 tasks
hueifeng
pushed a commit
to hueifeng/cli
that referenced
this pull request
Jul 18, 2022
* Script for docker install instead of actions-setup-docker Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * trigger pr checks Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Signed-off-by: hueifeng <695979933@qq.com>
hueifeng
added a commit
to hueifeng/cli
that referenced
this pull request
Jul 18, 2022
* Modify path DaprRoot add the SystemDrive environment variable Signed-off-by: HueiFeng <695979933@qq.com> * Script for docker install instead of actions-setup-docker (dapr#986) * Script for docker install instead of actions-setup-docker Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * trigger pr checks Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Signed-off-by: HueiFeng <695979933@qq.com> * Format output of dapr --version as JSON. (dapr#878) * Format output of dapr --version as JSON. Signed-off-by: fanfanbj <fanfanbj@outlook.com> * Format output of dapr --version as JSON. Signed-off-by: fanfanbj <fanfanbj@outlook.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: HueiFeng <695979933@qq.com> * Fix for panic during upgrade of edge version dapr (dapr#983) * Fix for panic during upgrade of edge version dapr Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * change console log message Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: HueiFeng <695979933@qq.com> * Add dapr annotate command (dapr#873) * Add dapr inject command Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Add additional opts Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Update comment regarding injection Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix some linting issues (more to go) Signed-off-by: Joni Collinge <jonathancollinge@live.com> * use existing const in tests Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix some more linting Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix some more linting Signed-off-by: Joni Collinge <jonathancollinge@live.com> * udpate tests Signed-off-by: Joni Collinge <jonathancollinge@live.com> * udpate tests Signed-off-by: Joni Collinge <jonathancollinge@live.com> * add option to run against a URL Signed-off-by: Joni Collinge <jonathancollinge@live.com> * refactor cmd/inject.go slightly Signed-off-by: Joni Collinge <jonathancollinge@live.com> * update example text Signed-off-by: Joni Collinge <jonathancollinge@live.com> * autogenerate appid if not present Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Update comment Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Add support for target namespace Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Update comment Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Add warning about app id generation to usage Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix linting issues Signed-off-by: Joni Collinge <jonathancollinge@live.com> * rename inject to annotate Signed-off-by: Joni Collinge <jonathancollinge@live.com> * go mod tidy Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix lint Signed-off-by: Joni Collinge <jonathancollinge@live.com> * update --help URL Signed-off-by: Joni Collinge <jonathancollinge@live.com> * add README.md seciton Signed-off-by: Joni Collinge <jonathancollinge@live.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: HueiFeng <695979933@qq.com> * Update go version to 1.18 (dapr#982) * Update go version to 1.18 Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * Bumping golangci-lint Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Signed-off-by: HueiFeng <695979933@qq.com> * adding dapr-http-read-buffer-size parameter to cli Signed-off-by: HueiFeng <695979933@qq.com> Co-authored-by: Pravin Pushkar <ppushkar@microsoft.com> Co-authored-by: FanBin <fanfanbj@outlook.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Co-authored-by: Joni Collinge <jonathancollinge@live.com> Signed-off-by: hueifeng <695979933@qq.com>
hueifeng
pushed a commit
to hueifeng/cli
that referenced
this pull request
Jul 29, 2022
* Script for docker install instead of actions-setup-docker Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * trigger pr checks Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Signed-off-by: hueifeng <695979933@qq.com>
hueifeng
added a commit
to hueifeng/cli
that referenced
this pull request
Jul 29, 2022
* Modify path DaprRoot add the SystemDrive environment variable Signed-off-by: HueiFeng <695979933@qq.com> * Script for docker install instead of actions-setup-docker (dapr#986) * Script for docker install instead of actions-setup-docker Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * trigger pr checks Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Signed-off-by: HueiFeng <695979933@qq.com> * Format output of dapr --version as JSON. (dapr#878) * Format output of dapr --version as JSON. Signed-off-by: fanfanbj <fanfanbj@outlook.com> * Format output of dapr --version as JSON. Signed-off-by: fanfanbj <fanfanbj@outlook.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: HueiFeng <695979933@qq.com> * Fix for panic during upgrade of edge version dapr (dapr#983) * Fix for panic during upgrade of edge version dapr Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * change console log message Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: HueiFeng <695979933@qq.com> * Add dapr annotate command (dapr#873) * Add dapr inject command Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Add additional opts Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Update comment regarding injection Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix some linting issues (more to go) Signed-off-by: Joni Collinge <jonathancollinge@live.com> * use existing const in tests Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix some more linting Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix some more linting Signed-off-by: Joni Collinge <jonathancollinge@live.com> * udpate tests Signed-off-by: Joni Collinge <jonathancollinge@live.com> * udpate tests Signed-off-by: Joni Collinge <jonathancollinge@live.com> * add option to run against a URL Signed-off-by: Joni Collinge <jonathancollinge@live.com> * refactor cmd/inject.go slightly Signed-off-by: Joni Collinge <jonathancollinge@live.com> * update example text Signed-off-by: Joni Collinge <jonathancollinge@live.com> * autogenerate appid if not present Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Update comment Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Add support for target namespace Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Update comment Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Add warning about app id generation to usage Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix linting issues Signed-off-by: Joni Collinge <jonathancollinge@live.com> * rename inject to annotate Signed-off-by: Joni Collinge <jonathancollinge@live.com> * go mod tidy Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix lint Signed-off-by: Joni Collinge <jonathancollinge@live.com> * update --help URL Signed-off-by: Joni Collinge <jonathancollinge@live.com> * add README.md seciton Signed-off-by: Joni Collinge <jonathancollinge@live.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: HueiFeng <695979933@qq.com> * Update go version to 1.18 (dapr#982) * Update go version to 1.18 Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * Bumping golangci-lint Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Signed-off-by: HueiFeng <695979933@qq.com> * adding dapr-http-read-buffer-size parameter to cli Signed-off-by: HueiFeng <695979933@qq.com> Co-authored-by: Pravin Pushkar <ppushkar@microsoft.com> Co-authored-by: FanBin <fanfanbj@outlook.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Co-authored-by: Joni Collinge <jonathancollinge@live.com> Signed-off-by: hueifeng <695979933@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pravin Pushkar ppushkar@microsoft.com
Description
Switching to
brew installinstead of usingactions-setup-dockergithub action, as with the action docker setup seems highly unstable. This way it might increase the time to setup docker on macos (can take upto 10 mins) but atleast it looks more stable. It failed once in last 4 runs. See here- https://github.com/pravinpushkar/cli/actions/workflows/self_hosted_e2e.yamlRelated discussions can be found here - docker/for-mac#2359
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #981
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: