-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding dapr-http-read-buffer-size parameter to cli #993
adding dapr-http-read-buffer-size parameter to cli #993
Conversation
Signed-off-by: HueiFeng <695979933@qq.com>
* Script for docker install instead of actions-setup-docker Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * trigger pr checks Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Signed-off-by: HueiFeng <695979933@qq.com>
* Format output of dapr --version as JSON. Signed-off-by: fanfanbj <fanfanbj@outlook.com> * Format output of dapr --version as JSON. Signed-off-by: fanfanbj <fanfanbj@outlook.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: HueiFeng <695979933@qq.com>
* Fix for panic during upgrade of edge version dapr Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * change console log message Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: HueiFeng <695979933@qq.com>
* Add dapr inject command Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Add additional opts Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Update comment regarding injection Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix some linting issues (more to go) Signed-off-by: Joni Collinge <jonathancollinge@live.com> * use existing const in tests Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix some more linting Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix some more linting Signed-off-by: Joni Collinge <jonathancollinge@live.com> * udpate tests Signed-off-by: Joni Collinge <jonathancollinge@live.com> * udpate tests Signed-off-by: Joni Collinge <jonathancollinge@live.com> * add option to run against a URL Signed-off-by: Joni Collinge <jonathancollinge@live.com> * refactor cmd/inject.go slightly Signed-off-by: Joni Collinge <jonathancollinge@live.com> * update example text Signed-off-by: Joni Collinge <jonathancollinge@live.com> * autogenerate appid if not present Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Update comment Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Add support for target namespace Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Update comment Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Add warning about app id generation to usage Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix linting issues Signed-off-by: Joni Collinge <jonathancollinge@live.com> * rename inject to annotate Signed-off-by: Joni Collinge <jonathancollinge@live.com> * go mod tidy Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix lint Signed-off-by: Joni Collinge <jonathancollinge@live.com> * update --help URL Signed-off-by: Joni Collinge <jonathancollinge@live.com> * add README.md seciton Signed-off-by: Joni Collinge <jonathancollinge@live.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: HueiFeng <695979933@qq.com>
* Update go version to 1.18 Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * Bumping golangci-lint Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Signed-off-by: HueiFeng <695979933@qq.com>
Signed-off-by: HueiFeng <695979933@qq.com>
6ba84e5
to
bba4939
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, given that all workflow passes.
Codecov Report
@@ Coverage Diff @@
## master #993 +/- ##
==========================================
+ Coverage 29.25% 29.27% +0.01%
==========================================
Files 35 35
Lines 2242 2248 +6
==========================================
+ Hits 656 658 +2
- Misses 1512 1516 +4
Partials 74 74
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. subject to tests passing.
* Modify path DaprRoot add the SystemDrive environment variable Signed-off-by: HueiFeng <695979933@qq.com> * Script for docker install instead of actions-setup-docker (dapr#986) * Script for docker install instead of actions-setup-docker Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * trigger pr checks Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Signed-off-by: HueiFeng <695979933@qq.com> * Format output of dapr --version as JSON. (dapr#878) * Format output of dapr --version as JSON. Signed-off-by: fanfanbj <fanfanbj@outlook.com> * Format output of dapr --version as JSON. Signed-off-by: fanfanbj <fanfanbj@outlook.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: HueiFeng <695979933@qq.com> * Fix for panic during upgrade of edge version dapr (dapr#983) * Fix for panic during upgrade of edge version dapr Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * change console log message Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: HueiFeng <695979933@qq.com> * Add dapr annotate command (dapr#873) * Add dapr inject command Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Add additional opts Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Update comment regarding injection Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix some linting issues (more to go) Signed-off-by: Joni Collinge <jonathancollinge@live.com> * use existing const in tests Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix some more linting Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix some more linting Signed-off-by: Joni Collinge <jonathancollinge@live.com> * udpate tests Signed-off-by: Joni Collinge <jonathancollinge@live.com> * udpate tests Signed-off-by: Joni Collinge <jonathancollinge@live.com> * add option to run against a URL Signed-off-by: Joni Collinge <jonathancollinge@live.com> * refactor cmd/inject.go slightly Signed-off-by: Joni Collinge <jonathancollinge@live.com> * update example text Signed-off-by: Joni Collinge <jonathancollinge@live.com> * autogenerate appid if not present Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Update comment Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Add support for target namespace Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Update comment Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Add warning about app id generation to usage Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix linting issues Signed-off-by: Joni Collinge <jonathancollinge@live.com> * rename inject to annotate Signed-off-by: Joni Collinge <jonathancollinge@live.com> * go mod tidy Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix lint Signed-off-by: Joni Collinge <jonathancollinge@live.com> * update --help URL Signed-off-by: Joni Collinge <jonathancollinge@live.com> * add README.md seciton Signed-off-by: Joni Collinge <jonathancollinge@live.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: HueiFeng <695979933@qq.com> * Update go version to 1.18 (dapr#982) * Update go version to 1.18 Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * Bumping golangci-lint Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Signed-off-by: HueiFeng <695979933@qq.com> * adding dapr-http-read-buffer-size parameter to cli Signed-off-by: HueiFeng <695979933@qq.com> Co-authored-by: Pravin Pushkar <ppushkar@microsoft.com> Co-authored-by: FanBin <fanfanbj@outlook.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Co-authored-by: Joni Collinge <jonathancollinge@live.com> Signed-off-by: hueifeng <695979933@qq.com>
* Modify path DaprRoot add the SystemDrive environment variable Signed-off-by: HueiFeng <695979933@qq.com> * Script for docker install instead of actions-setup-docker (dapr#986) * Script for docker install instead of actions-setup-docker Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * trigger pr checks Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Signed-off-by: HueiFeng <695979933@qq.com> * Format output of dapr --version as JSON. (dapr#878) * Format output of dapr --version as JSON. Signed-off-by: fanfanbj <fanfanbj@outlook.com> * Format output of dapr --version as JSON. Signed-off-by: fanfanbj <fanfanbj@outlook.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: HueiFeng <695979933@qq.com> * Fix for panic during upgrade of edge version dapr (dapr#983) * Fix for panic during upgrade of edge version dapr Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * change console log message Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: HueiFeng <695979933@qq.com> * Add dapr annotate command (dapr#873) * Add dapr inject command Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Add additional opts Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Update comment regarding injection Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix some linting issues (more to go) Signed-off-by: Joni Collinge <jonathancollinge@live.com> * use existing const in tests Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix some more linting Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix some more linting Signed-off-by: Joni Collinge <jonathancollinge@live.com> * udpate tests Signed-off-by: Joni Collinge <jonathancollinge@live.com> * udpate tests Signed-off-by: Joni Collinge <jonathancollinge@live.com> * add option to run against a URL Signed-off-by: Joni Collinge <jonathancollinge@live.com> * refactor cmd/inject.go slightly Signed-off-by: Joni Collinge <jonathancollinge@live.com> * update example text Signed-off-by: Joni Collinge <jonathancollinge@live.com> * autogenerate appid if not present Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Update comment Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Add support for target namespace Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Update comment Signed-off-by: Joni Collinge <jonathancollinge@live.com> * Add warning about app id generation to usage Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix linting issues Signed-off-by: Joni Collinge <jonathancollinge@live.com> * rename inject to annotate Signed-off-by: Joni Collinge <jonathancollinge@live.com> * go mod tidy Signed-off-by: Joni Collinge <jonathancollinge@live.com> * fix lint Signed-off-by: Joni Collinge <jonathancollinge@live.com> * update --help URL Signed-off-by: Joni Collinge <jonathancollinge@live.com> * add README.md seciton Signed-off-by: Joni Collinge <jonathancollinge@live.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: HueiFeng <695979933@qq.com> * Update go version to 1.18 (dapr#982) * Update go version to 1.18 Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * Bumping golangci-lint Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Signed-off-by: HueiFeng <695979933@qq.com> * adding dapr-http-read-buffer-size parameter to cli Signed-off-by: HueiFeng <695979933@qq.com> Co-authored-by: Pravin Pushkar <ppushkar@microsoft.com> Co-authored-by: FanBin <fanfanbj@outlook.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Co-authored-by: Joni Collinge <jonathancollinge@live.com> Signed-off-by: hueifeng <695979933@qq.com>
Description
adding dapr-http-read-buffer-size parameter to cli
Issue reference
#991
Please reference the issue this PR will close: #991
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: