Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding dapr-http-read-buffer-size parameter to cli #993

Merged
merged 8 commits into from
Jun 9, 2022

Conversation

hueifeng
Copy link
Member

@hueifeng hueifeng commented Jun 3, 2022

Description

adding dapr-http-read-buffer-size parameter to cli

Issue reference

#991

Please reference the issue this PR will close: #991

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@hueifeng hueifeng requested review from a team as code owners June 3, 2022 08:40
hueifeng and others added 7 commits June 3, 2022 17:19
Signed-off-by: HueiFeng <695979933@qq.com>
* Script for docker install instead of actions-setup-docker

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* trigger pr checks

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Signed-off-by: HueiFeng <695979933@qq.com>
* Format output of dapr --version as JSON.

Signed-off-by: fanfanbj <fanfanbj@outlook.com>

* Format output of dapr --version as JSON.

Signed-off-by: fanfanbj <fanfanbj@outlook.com>

Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Signed-off-by: HueiFeng <695979933@qq.com>
* Fix for panic during upgrade of edge version dapr

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* change console log message

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Signed-off-by: HueiFeng <695979933@qq.com>
* Add dapr inject command

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* Add additional opts

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* Update comment regarding injection

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* fix some linting issues (more to go)

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* use existing const in tests

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* fix some more linting

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* fix some more linting

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* udpate tests

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* udpate tests

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* add option to run against a URL

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* refactor cmd/inject.go slightly

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* update example text

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* autogenerate appid if not present

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* Update comment

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* Add support for target namespace

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* Update comment

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* Add warning about app id generation to usage

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* fix linting issues

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* rename inject to annotate

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* go mod tidy

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* fix lint

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* update --help URL

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* add README.md seciton

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Signed-off-by: HueiFeng <695979933@qq.com>
* Update go version to 1.18

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* Bumping golangci-lint

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Signed-off-by: HueiFeng <695979933@qq.com>
Signed-off-by: HueiFeng <695979933@qq.com>
@hueifeng hueifeng force-pushed the dapr-http-read-buffer-size branch from 6ba84e5 to bba4939 Compare June 3, 2022 09:19
Copy link
Contributor

@pravinpushkar pravinpushkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, given that all workflow passes.

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #993 (0c748ab) into master (0630996) will increase coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #993      +/-   ##
==========================================
+ Coverage   29.25%   29.27%   +0.01%     
==========================================
  Files          35       35              
  Lines        2242     2248       +6     
==========================================
+ Hits          656      658       +2     
- Misses       1512     1516       +4     
  Partials       74       74              
Impacted Files Coverage Δ
pkg/standalone/list.go 7.95% <0.00%> (-0.38%) ⬇️
pkg/standalone/run.go 60.00% <100.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3abbf3f...0c748ab. Read the comment docs.

Copy link
Collaborator

@mukundansundar mukundansundar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. subject to tests passing.

@mukundansundar mukundansundar merged commit b85eee4 into dapr:master Jun 9, 2022
hueifeng added a commit to hueifeng/cli that referenced this pull request Jul 18, 2022
* Modify path DaprRoot add the SystemDrive environment variable

Signed-off-by: HueiFeng <695979933@qq.com>

* Script for docker install instead of actions-setup-docker (dapr#986)

* Script for docker install instead of actions-setup-docker

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* trigger pr checks

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Signed-off-by: HueiFeng <695979933@qq.com>

* Format output of dapr --version as JSON.  (dapr#878)

* Format output of dapr --version as JSON.

Signed-off-by: fanfanbj <fanfanbj@outlook.com>

* Format output of dapr --version as JSON.

Signed-off-by: fanfanbj <fanfanbj@outlook.com>

Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Signed-off-by: HueiFeng <695979933@qq.com>

* Fix for panic during upgrade of edge version dapr (dapr#983)

* Fix for panic during upgrade of edge version dapr

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* change console log message

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Signed-off-by: HueiFeng <695979933@qq.com>

* Add dapr annotate command (dapr#873)

* Add dapr inject command

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* Add additional opts

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* Update comment regarding injection

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* fix some linting issues (more to go)

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* use existing const in tests

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* fix some more linting

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* fix some more linting

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* udpate tests

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* udpate tests

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* add option to run against a URL

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* refactor cmd/inject.go slightly

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* update example text

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* autogenerate appid if not present

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* Update comment

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* Add support for target namespace

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* Update comment

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* Add warning about app id generation to usage

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* fix linting issues

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* rename inject to annotate

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* go mod tidy

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* fix lint

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* update --help URL

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* add README.md seciton

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Signed-off-by: HueiFeng <695979933@qq.com>

* Update go version to 1.18 (dapr#982)

* Update go version to 1.18

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* Bumping golangci-lint

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Signed-off-by: HueiFeng <695979933@qq.com>

* adding dapr-http-read-buffer-size parameter to cli

Signed-off-by: HueiFeng <695979933@qq.com>

Co-authored-by: Pravin Pushkar <ppushkar@microsoft.com>
Co-authored-by: FanBin <fanfanbj@outlook.com>
Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Co-authored-by: Joni Collinge <jonathancollinge@live.com>
Signed-off-by: hueifeng <695979933@qq.com>
hueifeng added a commit to hueifeng/cli that referenced this pull request Jul 29, 2022
* Modify path DaprRoot add the SystemDrive environment variable

Signed-off-by: HueiFeng <695979933@qq.com>

* Script for docker install instead of actions-setup-docker (dapr#986)

* Script for docker install instead of actions-setup-docker

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* trigger pr checks

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Signed-off-by: HueiFeng <695979933@qq.com>

* Format output of dapr --version as JSON.  (dapr#878)

* Format output of dapr --version as JSON.

Signed-off-by: fanfanbj <fanfanbj@outlook.com>

* Format output of dapr --version as JSON.

Signed-off-by: fanfanbj <fanfanbj@outlook.com>

Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Signed-off-by: HueiFeng <695979933@qq.com>

* Fix for panic during upgrade of edge version dapr (dapr#983)

* Fix for panic during upgrade of edge version dapr

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* change console log message

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Signed-off-by: HueiFeng <695979933@qq.com>

* Add dapr annotate command (dapr#873)

* Add dapr inject command

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* Add additional opts

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* Update comment regarding injection

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* fix some linting issues (more to go)

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* use existing const in tests

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* fix some more linting

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* fix some more linting

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* udpate tests

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* udpate tests

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* add option to run against a URL

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* refactor cmd/inject.go slightly

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* update example text

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* autogenerate appid if not present

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* Update comment

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* Add support for target namespace

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* Update comment

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* Add warning about app id generation to usage

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* fix linting issues

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* rename inject to annotate

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* go mod tidy

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* fix lint

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* update --help URL

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

* add README.md seciton

Signed-off-by: Joni Collinge <jonathancollinge@live.com>

Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Signed-off-by: HueiFeng <695979933@qq.com>

* Update go version to 1.18 (dapr#982)

* Update go version to 1.18

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* Bumping golangci-lint

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Signed-off-by: HueiFeng <695979933@qq.com>

* adding dapr-http-read-buffer-size parameter to cli

Signed-off-by: HueiFeng <695979933@qq.com>

Co-authored-by: Pravin Pushkar <ppushkar@microsoft.com>
Co-authored-by: FanBin <fanfanbj@outlook.com>
Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Co-authored-by: Joni Collinge <jonathancollinge@live.com>
Signed-off-by: hueifeng <695979933@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--dapr-http-read-buffer-size in the docs but not implemented
6 participants