Prefix chunks cache flags. #2241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1a5d49 to
9acf0f5
Compare
3 tasks
pracucci
reviewed
Mar 12, 2020
There was a problem hiding this comment.
@gouthamve For each changed CLI flag could you search references in docs/ and update it, please? There are some. It's a annoying work, but we have to do it to avoid doc drifts.
|
Thanks @pracucci, I thought I got them all, but somehow missed 2. Fixed those two as well! |
dfca015 to
05ae255
Compare
pstibrany
approved these changes
Mar 13, 2020
e03b8ab to
0ea70e8
Compare
pracucci
approved these changes
Mar 13, 2020
There was a problem hiding this comment.
Amazing work @gouthamve ! LGTM.
I left few minor comments. Pay attention that there are still some old flags references:
-memcached.(2 times) and-redis.(1 time) inarguments.md
| # memcache. | ||
| # CLI flag: -memcache.write-back-goroutines | ||
| # Cache config for chunks. At what concurrency to write back to cache. | ||
| # CLI flag: -store.chunks-cache.cache.write-back-concurrency | ||
| [writeback_goroutines: <int> | default = 10] |
There was a problem hiding this comment.
What do you think it's worth changing the YAML accordingly? Keep in mind that in other YAML config options the writeback is spelled writeback (without _ separator).
Fixes cortexproject#2191 Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Fixes cortexproject#553 Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
0ea70e8 to
50804fd
Compare
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
50804fd to
f486175
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2191 #553
Signed-off-by: Goutham Veeramachaneni gouthamve@gmail.com
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]