Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memcache option flags are inconsistent #553

Closed
bboreham opened this issue Aug 30, 2017 · 0 comments
Closed

memcache option flags are inconsistent #553

bboreham opened this issue Aug 30, 2017 · 0 comments
Labels
help wanted type/breaking
Milestone
v1

Comments

@bboreham
Copy link
Contributor

We have memcached.hostname, memcached.service and memcached.expiration, but memcache.write-back-goroutines and memcache.write-back-buffer

Unless I'm missing some subtlety in the naming, Cortex should pick one version of the name (d or no d) and stick to it.
@tomwilkie tomwilkie added this to the v1 milestone Feb 27, 2020
@gouthamve gouthamve mentioned this issue Mar 10, 2020
Merged
2 tasks
gouthamve added a commit to gouthamve/cortex that referenced this issue Mar 24, 2020
@gouthamve
Move background cache prefix to cache from memcache
4a4b3e6 
Fixes cortexproject#553

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted type/breaking
Projects
None yet
Milestone
v1
Development

No branches or pull requests
3 participants
@tomwilkie @gouthamve @bboreham